Page MenuHomePhabricator

[MS] Don't emit coverage for deleting dtors
ClosedPublic

Authored by rnk on Feb 26 2019, 11:30 AM.

Details

Summary

The MS C++ ABI has no constructor variants, but it has destructor
variants, so we should move the deleting destructor variant check
outside the check for "does the ABI have constructor variants".

Fixes PR37561, so basic code coverage works on Windows with C++.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Feb 26 2019, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2019, 11:30 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
vsk added inline comments.Feb 26 2019, 11:39 AM
clang/test/Profile/cxx-abc-deleting-dtor.cpp
28 ↗(On Diff #188427)

Probably not. IIUC the branches aren't visible at the source-level?

52 ↗(On Diff #188427)

Do you need {{[01]}}?

rnk updated this revision to Diff 188434.Feb 26 2019, 11:49 AM
rnk marked 3 inline comments as done.
  • fix CHECK-NOT
  • FIXME that isn't needed
clang/test/Profile/cxx-abc-deleting-dtor.cpp
28 ↗(On Diff #188427)

You're right, they aren't, so I'll remove this.

52 ↗(On Diff #188427)

Yes, thanks.

vsk accepted this revision.Feb 26 2019, 12:09 PM

Thanks! Lgtm.

This revision is now accepted and ready to land.Feb 26 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2019, 12:45 PM