Page MenuHomePhabricator

Improve process launch comments for Windows
ClosedPublic

Authored by amccarth on Feb 25 2019, 3:15 PM.

Details

Summary

The existing comment about over-allocating the command line was incorrect. The contents of the command line may be changed, but it's not necessary to over allocate. The changes will be limited to the existing contents of the string (e.g., by replacing spaces with L'\0' to tokenize the command line).

Also added a comment explaining a possible cause of failure to save the next programmer some time when they try to debug a 64-bit process from a 32-bit LLDB.

Diff Detail

Event Timeline

amccarth created this revision.Feb 25 2019, 3:15 PM
amccarth updated this revision to Diff 188263.Feb 25 2019, 3:19 PM

Forgot to include context in original diff.

labath accepted this revision.Feb 28 2019, 5:17 AM

Looks fine to me. If this "The request is not supported" error is something that makes it's way to the user, and the error code is reasonably unambiguous (it +/- only happens when debugging 64 bit process from 32bit lldb), you may want to consider changing the error message to something more understandable.

This revision is now accepted and ready to land.Feb 28 2019, 5:17 AM

Thanks. I really don't know what other types of conditions may trigger that "request is not supported" message, so I'm going to shy away from trying to make it more specific.

amccarth closed this revision.Feb 28 2019, 11:16 AM

Closed with r355121.