Index: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp =================================================================== --- clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp +++ clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp @@ -35,11 +35,42 @@ this); } +static bool isLikelyCharExpression(const Expr* Argument, const ASTContext &Ctx) { + const auto* BinOp = dyn_cast(Argument); + if (!BinOp) { + return false; + } + const auto* LHS = BinOp->getLHS()->IgnoreParenImpCasts(); + const auto* RHS = BinOp->getRHS()->IgnoreParenImpCasts(); + // & , mask is a compile time constant. + Expr::EvalResult RHSVal; + if (BinOp->getOpcode() == BO_And && + BinOp->getRHS()->EvaluateAsInt(RHSVal, Ctx, Expr::SE_AllowSideEffects)) { + return true; + } + // + ( % ), where is a char literal. + BinOp->dump(); + llvm::errs() << "A " << isa(LHS) << " " << (BinOp->getOpcode() == BO_Add)<< "\n"; + if (isa(LHS) && BinOp->getOpcode() == BO_Add) { + const auto* RHSOp = dyn_cast(RHS); + llvm::errs() << "B " << RHSOp << " " << (RHSOp ? RHSOp->getOpcode() == BO_Rem : false)<< "\n"; + if (RHSOp && RHSOp->getOpcode() == BO_Rem) { + return true; + } + } + return false; +} + void StringIntegerAssignmentCheck::check( const MatchFinder::MatchResult &Result) { const auto *Argument = Result.Nodes.getNodeAs("expr"); SourceLocation Loc = Argument->getBeginLoc(); + // Try to detect a few common expressions to reduce false positives. + if (isLikelyCharExpression(Argument, *Result.Context)) { + return; + } + auto Diag = diag(Loc, "an integer is interpreted as a character code when assigning " "it to a string; if this is intended, cast the integer to the " Index: test/clang-tidy/bugprone-string-integer-assignment.cpp =================================================================== --- test/clang-tidy/bugprone-string-integer-assignment.cpp +++ test/clang-tidy/bugprone-string-integer-assignment.cpp @@ -50,4 +50,8 @@ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara // CHECK-FIXES: {{^}} as = 6;{{$}} + // Likely character expressions. + s += x & 0xff; + + s += 'a' + (x % 26); }