Index: clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp @@ -26,7 +26,8 @@ hasOverloadedOperatorName("+=")), callee(cxxMethodDecl(ofClass(classTemplateSpecializationDecl( hasName("::std::basic_string"), - hasTemplateArgument(0, refersToType(qualType().bind("type"))))))), + hasTemplateArgument(0, refersToType(hasCanonicalType( + qualType().bind("type")))))))), hasArgument( 1, ignoringImpCasts( @@ -34,7 +35,11 @@ // Ignore calls to tolower/toupper (see PR27723). unless(callExpr(callee(functionDecl( hasAnyName("tolower", "std::tolower", "toupper", - "std::toupper")))))) + "std::toupper"))))), + // Do not warn if assigning e.g. `CodePoint` to + // `basic_string` + unless(hasType(qualType( + hasCanonicalType(equalsBoundNode("type")))))) .bind("expr"))), unless(isInTemplateInstantiation())), this); Index: clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp +++ clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp @@ -53,8 +53,8 @@ std::basic_string as; as = 6; -// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara -// CHECK-FIXES: {{^}} as = 6;{{$}} + as = static_cast(6); + as = 'a'; s += toupper(x); s += tolower(x);