Page MenuHomePhabricator
Differential D58283

[X86] Fix LowerAsmOutputForConstraint.
ClosedPublic
Actions

Authored by niravd on Feb 15 2019, 7:21 AM.

Details

Reviewers
rnk
nickdesaulniers
craig.topper
spatel
Commits
rG78758411217c: [X86] Fix LowerAsmOutputForConstraint.
rL354163: [X86] Fix LowerAsmOutputForConstraint.
Summary

Update Flag when generating cc output.

Fixes PR40737.

Diff Detail

Repository
rL LLVM

Event Timeline

niravd created this revision.Feb 15 2019, 7:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 7:21 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B28192: Diff 187016.Feb 15 2019, 7:22 AM
rnk accepted this revision.Feb 15 2019, 11:24 AM

lgtm

This revision is now accepted and ready to land.Feb 15 2019, 11:24 AM
mstorsjo added a subscriber: mstorsjo.Feb 15 2019, 11:32 AM

I tested and it seems good, I can build the whole mingw-w64 runtime again with this applied.

Closed by commit rL354163: [X86] Fix LowerAsmOutputForConstraint. (authored by niravd). · Explain WhyFeb 15 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
CodeGen/
2 lines
lib/
CodeGen/
SelectionDAG/
3 lines
2 lines
Target/
X86/
2 lines
13 lines
test/
CodeGen/
X86/
19 lines

Diff 187062

View Options

llvm/trunk/include/llvm/CodeGen/TargetLowering.h

Loading...
View Options

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Loading...
View Options

llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Loading...
View Options

llvm/trunk/lib/Target/X86/X86ISelLowering.h

Loading...
View Options

llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Loading...
View Options

llvm/trunk/test/CodeGen/X86/pr40737.ll

Loading...