Page MenuHomePhabricator
Differential D58274

[MergeICmps] Make base ordering really deterministic.
ClosedPublic
Actions

Authored by courbet on Feb 15 2019, 1:21 AM.

Details

Reviewers
gchatelet
Commits
rG25c79d978447: Merging r354128 and r354131:
rL354249: Merging r354128 and r354131:
rGf7e84a2ccc4b: [MergeICmps] Make base ordering really deterministic.
rL354131: [MergeICmps] Make base ordering really deterministic.
Summary

The idea is that we now manipulate bases through a unsigned BaseID based on
order of appearance in the comparison chain rather than through the Value*.

Fixes 40714.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Feb 15 2019, 1:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 1:21 AM
Herald added subscribers: jdoerfert, jfb, mgrang. · View Herald Transcript
Harbormaster completed remote builds in B28179: Diff 186974.Feb 15 2019, 1:22 AM
courbet updated this revision to Diff 186978.Feb 15 2019, 1:57 AM

use dense_map instead of unordered_map

Harbormaster completed remote builds in B28180: Diff 186978.Feb 15 2019, 2:02 AM
gchatelet added inline comments.Feb 15 2019, 2:11 AM
lib/Transforms/Scalar/MergeICmps.cpp
87 ↗(On Diff #186974)

Remove.

96 ↗(On Diff #186974)

Remove

106 ↗(On Diff #186974)

You may keep {} for consistency with BCECmpBlock below.

courbet updated this revision to Diff 186996.Feb 15 2019, 4:53 AM
courbet marked 2 inline comments as done.

use {} instead of BCEAtom().

Harbormaster completed remote builds in B28186: Diff 186996.Feb 15 2019, 4:56 AM
courbet updated this revision to Diff 186997.Feb 15 2019, 4:58 AM

rebase

Harbormaster completed remote builds in B28187: Diff 186997.Feb 15 2019, 4:58 AM
gchatelet accepted this revision.Feb 15 2019, 5:03 AM
This revision is now accepted and ready to land.Feb 15 2019, 5:03 AM
Closed by commit rL354131: [MergeICmps] Make base ordering really deterministic. (authored by courbet). · Explain WhyFeb 15 2019, 6:21 AM
This revision was automatically updated to reflect the committed changes.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Transforms/
Scalar/
194 lines

Diff 187005

View Options

llvm/trunk/lib/Transforms/Scalar/MergeICmps.cpp

Loading...