Page MenuHomePhabricator

[dotest] Fix compiler version number comparison
ClosedPublic

Authored by friss on Feb 13 2019, 4:48 PM.

Details

Summary

dotest's version comparision function is just a lexicographical compare
of the version strings. This is obviously wrong. This patch implements
a numerical comparision of the individual version components instead.

Python is not my language of choice, please suggest a better implementation!

Event Timeline

friss created this revision.Feb 13 2019, 4:48 PM
friss updated this revision to Diff 186782.Feb 13 2019, 5:42 PM

Use LooseVersion as suggested by Zachary

labath accepted this revision.Feb 13 2019, 10:51 PM
This revision is now accepted and ready to land.Feb 13 2019, 10:51 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2019, 10:51 AM