Differential D58162

[hwasan] Runtime flags for malloc bisection.
ClosedPublic
Actions

Authored by eugenis on Feb 12 2019, 5:50 PM.

Tags

Subscribers

Restricted Project

Details

Reviewers

kcc
pcc

Commits

rGa70d88c7a30f: Runtime flags for malloc bisection.
rL354156: Runtime flags for malloc bisection.
rCRT354156: Runtime flags for malloc bisection.

Diff Detail

Repository: rCRT Compiler Runtime

Event Timeline

eugenis created this revision.Feb 12 2019, 5:50 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 5:50 PM

Herald added subscribers: jdoerfert, mgorny, kubamracek. · View Herald Transcript

Harbormaster completed remote builds in B28082: Diff 186575.Feb 12 2019, 5:52 PM

Eugene.Zelenko added a subscriber: Eugene.Zelenko.Feb 12 2019, 6:30 PM

Eugene.Zelenko added inline comments.

compiler-rt/lib/sanitizer_common/sanitizer_hash.h
11 ↗	(On Diff #186575)	Please insert empty line above.

added an empty line

Herald added a subscriber: jfb. · View Herald TranscriptFeb 13 2019, 1:27 PM

Harbormaster completed remote builds in B28114: Diff 186728.Feb 13 2019, 1:27 PM

eugenis marked an inline comment as done.Feb 13 2019, 1:27 PM

revert unrelated changes

Harbormaster completed remote builds in B28115: Diff 186729.Feb 13 2019, 1:33 PM

LGTM

compiler-rt/lib/hwasan/CMakeLists.txt
28 ↗	(On Diff #186729)	nit: alphabetical order
compiler-rt/test/hwasan/TestCases/malloc_bisect.c
5 ↗	(On Diff #186729)	Should this be 2^32 - 1 to prevent the test from being sensitive to the test environment?

This revision is now accepted and ready to land.Feb 15 2019, 9:58 AM

address comments

Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 10:33 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

eugenis marked 2 inline comments as done.Feb 15 2019, 10:33 AM

Harbormaster completed remote builds in B28199: Diff 187038.Feb 15 2019, 10:35 AM

Closed by commit rCRT354156: Runtime flags for malloc bisection. (authored by eugenis). · Explain WhyFeb 15 2019, 10:38 AM

This revision was automatically updated to reflect the committed changes.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

Path

Size

lib/

hwasan/

1 line

hwasan_allocator.cc

5 lines

hwasan_flags.inc

13 lines

hwasan_malloc_bisect.h

50 lines

sanitizer_common/

1 line

sanitizer_hash.h

43 lines

sanitizer_stackdepot.cc

21 lines

test/

hwasan/

TestCases/

malloc_bisect.c

26 lines

Diff 187040

lib/hwasan/CMakeLists.txt

Loading...

lib/hwasan/hwasan_allocator.cc

Loading...

lib/hwasan/hwasan_flags.inc

Loading...

lib/hwasan/hwasan_malloc_bisect.h

Loading...

lib/sanitizer_common/CMakeLists.txt

Loading...

lib/sanitizer_common/sanitizer_hash.h

Loading...

lib/sanitizer_common/sanitizer_stackdepot.cc

Loading...

test/hwasan/TestCases/malloc_bisect.c

Loading...