[hwasan] Fix false positive when tag_in_malloc=0,tag_in_free=1.
ClosedPublic
Actions

Authored by eugenis on Feb 12 2019, 4:46 PM.

Details

Reviewers

pcc
kcc

Commits

rG2c0483f5a6e0: Fix false positive when tag_in_malloc=0,tag_in_free=1.
rL354155: Fix false positive when tag_in_malloc=0,tag_in_free=1.
rCRT354155: Fix false positive when tag_in_malloc=0,tag_in_free=1.

Summary

With tag_in_free=1, malloc() can not assume that the memory is untagged,
and needs to retag is to 0.

Diff Detail

Repository: rCRT Compiler Runtime

Event Timeline

eugenis created this revision.Feb 12 2019, 4:46 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 4:46 PM

Herald added subscribers: jdoerfert, jfb, kubamracek. · View Herald Transcript

Harbormaster completed remote builds in B28076: Diff 186562.Feb 12 2019, 4:46 PM

+ a comment in test

Harbormaster completed remote builds in B28077: Diff 186564.Feb 12 2019, 4:48 PM

LGTM

This revision is now accepted and ready to land.Feb 15 2019, 9:38 AM

Closed by commit rCRT354155: Fix false positive when tag_in_malloc=0,tag_in_free=1. (authored by eugenis). · Explain WhyFeb 15 2019, 10:37 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 10:37 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

Path

Size

lib/

hwasan/

hwasan_allocator.cc

14 lines

test/

hwasan/

TestCases/

tag_in_free.c

51 lines

Diff 187039

View Options

lib/hwasan/hwasan_allocator.cc