Page MenuHomePhabricator

[AArch64][GlobalSel] Add isel support for a couple vector exts/truncs
ClosedPublic

Authored by paquette on Feb 6 2019, 11:22 AM.

Details

Summary

Add support for

  • v4s16 <-> v4s32
  • v2s64 <-> v2s32

And update tests that use them to show that we generate the correct instructions.

Diff Detail

Event Timeline

paquette created this revision.Feb 6 2019, 11:22 AM

I think if you're going to have a new separate test, you might as well make it a MIR test for the selector (just use update_mir_test_checks.py) instead of an IR test which already exists in arm64-vcvt_f.ll.

paquette updated this revision to Diff 186288.Feb 11 2019, 10:28 AM

Updated existing .mir test instead of adding a .ll test

arsenm added a subscriber: arsenm.Feb 11 2019, 10:33 AM
arsenm added inline comments.
test/CodeGen/AArch64/GlobalISel/select-fp-casts.mir
5–7 ↗(On Diff #186288)

You shouldn't need the IR section at all in this test. Maybe a pre-commit to remove this?

paquette marked 2 inline comments as done.Feb 11 2019, 10:41 AM
paquette added inline comments.
test/CodeGen/AArch64/GlobalISel/select-fp-casts.mir
5–7 ↗(On Diff #186288)

Good idea. r353731.

paquette updated this revision to Diff 186291.Feb 11 2019, 10:43 AM
paquette marked an inline comment as done.

Rebased after removing redundant IR from existing .mir test

paquette retitled this revision from [AArch64][GlobalISe] Add isel support for a couple vector exts/truncs to [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.Feb 11 2019, 10:44 AM
This revision is now accepted and ready to land.Feb 11 2019, 10:55 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 10:58 AM
Herald added a subscriber: hiraditya. · View Herald Transcript