Page MenuHomePhabricator

[clang] Add getCommentHandler to PreambleCallbacks
ClosedPublic

Authored by kadircet on Jan 31 2019, 4:49 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kadircet created this revision.Jan 31 2019, 4:49 AM
ilya-biryukov accepted this revision.Jan 31 2019, 10:21 AM

LGTM, just a few nits

include/clang/Frontend/PrecompiledPreamble.h
286 ↗(On Diff #184484)

NIT: this function does not add anything by itself, maybe rephrase to avoid confusion, e.g. The returned CommentHandler will be added to the preprocessor if not null.

NIT: Use Preprocessor or preprocessor. It seems to be always spelled as a single word.

This revision is now accepted and ready to land.Jan 31 2019, 10:21 AM
kadircet updated this revision to Diff 184998.Feb 4 2019, 1:08 AM
kadircet marked an inline comment as done.
  • Update comment
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 1:42 AM