Index: llvm/tools/llvm-readobj/ELFDumper.cpp =================================================================== --- llvm/tools/llvm-readobj/ELFDumper.cpp +++ llvm/tools/llvm-readobj/ELFDumper.cpp @@ -153,6 +153,7 @@ void printDynamicTable() override; void printNeededLibraries() override; + void printSectionMapping() override; void printProgramHeaders() override; void printHashTable() override; void printGnuHashTable() override; @@ -337,6 +338,7 @@ virtual void printSymbol(const ELFFile *Obj, const Elf_Sym *Symbol, const Elf_Sym *FirstSym, StringRef StrTable, bool IsDynamic) = 0; + virtual void printSectionMapping(const ELFFile *Obj) = 0; virtual void printProgramHeaders(const ELFFile *Obj) = 0; virtual void printHashHistogram(const ELFFile *Obj) = 0; virtual void printCGProfile(const ELFFile *Obj) = 0; @@ -370,6 +372,7 @@ void printDynamicRelocations(const ELFO *Obj) override; void printSymtabMessage(const ELFO *Obj, StringRef Name, size_t Offset) override; + void printSectionMapping(const ELFO *Obj) override; void printProgramHeaders(const ELFO *Obj) override; void printHashHistogram(const ELFFile *Obj) override; void printCGProfile(const ELFFile *Obj) override; @@ -461,6 +464,7 @@ void printSymbols(const ELFO *Obj, bool PrintSymbols, bool PrintDynamicSymbols) override; void printDynamicRelocations(const ELFO *Obj) override; + void printSectionMapping(const ELFO *Obj) override {} void printProgramHeaders(const ELFO *Obj) override; void printHashHistogram(const ELFFile *Obj) override; void printCGProfile(const ELFFile *Obj) override; @@ -1615,6 +1619,10 @@ ELFDumperStyle->printRelocations(ObjF->getELFFile()); } +template void ELFDumper::printSectionMapping() { + ELFDumperStyle->printSectionMapping(ObjF->getELFFile()); +} + template void ELFDumper::printProgramHeaders() { ELFDumperStyle->printProgramHeaders(ObjF->getELFFile()); } @@ -3309,6 +3317,31 @@ (Sec.sh_addr > Phdr.p_vaddr && Sec.sh_addr < Phdr.p_memsz)); } +template +void GNUStyle::printSectionMapping(const ELFO *Obj) { + OS << "\n Section to Segment mapping:\n Segment Sections...\n"; + int Phnum = 0; + for (const Elf_Phdr &Phdr : unwrapOrError(Obj->program_headers())) { + std::string Sections; + OS << format(" %2.2d ", Phnum++); + for (const Elf_Shdr &Sec : unwrapOrError(Obj->sections())) { + // Check if each section is in a segment and then print mapping. + // readelf additionally makes sure it does not print zero sized sections + // at end of segments and for PT_DYNAMIC both start and end of section + // .tbss must only be shown in PT_TLS section. + bool TbssInNonTLS = (Sec.sh_type == ELF::SHT_NOBITS) && + ((Sec.sh_flags & ELF::SHF_TLS) != 0) && + Phdr.p_type != ELF::PT_TLS; + if (!TbssInNonTLS && checkTLSSections(Phdr, Sec) && + checkoffsets(Phdr, Sec) && checkVMA(Phdr, Sec) && + checkPTDynamic(Phdr, Sec) && (Sec.sh_type != ELF::SHT_NULL)) + Sections += unwrapOrError(Obj->getSectionName(&Sec)).str() + " "; + } + OS << Sections << "\n"; + OS.flush(); + } +} + template void GNUStyle::printProgramHeaders(const ELFO *Obj) { unsigned Bias = ELFT::Is64Bits ? 8 : 0; @@ -3356,27 +3389,6 @@ } OS << "\n"; } - OS << "\n Section to Segment mapping:\n Segment Sections...\n"; - int Phnum = 0; - for (const Elf_Phdr &Phdr : unwrapOrError(Obj->program_headers())) { - std::string Sections; - OS << format(" %2.2d ", Phnum++); - for (const Elf_Shdr &Sec : unwrapOrError(Obj->sections())) { - // Check if each section is in a segment and then print mapping. - // readelf additionally makes sure it does not print zero sized sections - // at end of segments and for PT_DYNAMIC both start and end of section - // .tbss must only be shown in PT_TLS section. - bool TbssInNonTLS = (Sec.sh_type == ELF::SHT_NOBITS) && - ((Sec.sh_flags & ELF::SHF_TLS) != 0) && - Phdr.p_type != ELF::PT_TLS; - if (!TbssInNonTLS && checkTLSSections(Phdr, Sec) && - checkoffsets(Phdr, Sec) && checkVMA(Phdr, Sec) && - checkPTDynamic(Phdr, Sec) && (Sec.sh_type != ELF::SHT_NULL)) - Sections += unwrapOrError(Obj->getSectionName(&Sec)).str() + " "; - } - OS << Sections << "\n"; - OS.flush(); - } } template Index: llvm/tools/llvm-readobj/ObjDumper.h =================================================================== --- llvm/tools/llvm-readobj/ObjDumper.h +++ llvm/tools/llvm-readobj/ObjDumper.h @@ -46,6 +46,7 @@ virtual void printDynamicRelocations() { } virtual void printDynamicTable() { } virtual void printNeededLibraries() { } + virtual void printSectionMapping() { } virtual void printProgramHeaders() { } virtual void printSectionAsHex(StringRef SectionName) {} virtual void printHashTable() { } Index: llvm/tools/llvm-readobj/llvm-readobj.cpp =================================================================== --- llvm/tools/llvm-readobj/llvm-readobj.cpp +++ llvm/tools/llvm-readobj/llvm-readobj.cpp @@ -106,6 +106,11 @@ cl::opt SectionData("section-data", cl::desc("Display section data for each section shown.")); + // -section-mapping + cl::opt + SectionMapping("section-mapping", + cl::desc("Display the section to segment mapping.")); + // -relocations, -relocs, -r cl::opt Relocations("relocations", cl::desc("Display the relocation entries in the file")); @@ -460,6 +465,8 @@ Dumper->printFileHeaders(); if (opts::SectionHeaders) Dumper->printSectionHeaders(); + if (opts::SectionMapping) + Dumper->printSectionMapping(); if (opts::Relocations) Dumper->printRelocations(); if (opts::DynRelocs) @@ -474,8 +481,10 @@ Dumper->printDynamicTable(); if (opts::NeededLibraries) Dumper->printNeededLibraries(); - if (opts::ProgramHeaders) + if (opts::ProgramHeaders) { Dumper->printProgramHeaders(); + Dumper->printSectionMapping(); + } if (!opts::StringDump.empty()) llvm::for_each(opts::StringDump, [&Dumper, Obj](StringRef SectionName) { Dumper->printSectionAsString(Obj, SectionName);