Differential D57080

[clang-tidy] Delete obsolete objc-property-declaration options ✂️
ClosedPublic
Actions

Authored by stephanemoore on Jan 22 2019, 7:56 PM.

Tags

Subscribers

Details

Reviewers

Eugene.Zelenko
aaron.ballman

Commits

rG358f99c7fe27: [clang-tidy] Delete obsolete objc-property-declaration options ✂️
rCTE354195: [clang-tidy] Delete obsolete objc-property-declaration options ✂️
rL354195: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

Summary

The Acronyms and IncludeDefaultAcronyms options were deprecated in
https://reviews.llvm.org/D51832. These options can be removed.

Tested by running the clang-tidy tests.

This is an amended resubmission of https://reviews.llvm.org/D56945.

Diff Detail

Repository: rL LLVM

Event Timeline

stephanemoore created this revision.Jan 22 2019, 7:56 PM

Herald added subscribers: cfe-commits, xazax.hun. · View Herald TranscriptJan 22 2019, 7:56 PM

stephanemoore edited the summary of this revision. (Show Details)Jan 22 2019, 7:57 PM

Harbormaster completed remote builds in B27185: Diff 183027.Jan 22 2019, 7:57 PM

stephanemoore added reviewers: Eugene.Zelenko, aaron.ballman.Jan 22 2019, 7:58 PM

stephanemoore marked an inline comment as done.Jan 22 2019, 8:08 PM

stephanemoore added inline comments.

docs/ReleaseNotes.rst
76 ↗	(On Diff #183027)	In https://reviews.llvm.org/D56945, I implemented the recommendation to use the :option: prefix for these options but the documentation generator produced a warning for an unknown option which I imagine is due to the deletion of the options. I imagine that means we can't use the :option: prefix for deleted options? Please let me know if you have other suggestions.

Migrated patch to LLVM monorepo.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 5:23 PM

Harbormaster completed remote builds in B28081: Diff 186572.Feb 12 2019, 5:23 PM

LGTM!

This revision is now accepted and ready to land.Feb 13 2019, 6:34 AM

Closed by commit rL354195: [clang-tidy] Delete obsolete objc-property-declaration options ✂️ (authored by stephanemoore). · Explain WhyFeb 15 2019, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 8:28 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

Path

Size

clang-tools-extra/

trunk/

clang-tidy/

objc/

PropertyDeclarationCheck.h

11 lines

PropertyDeclarationCheck.cpp

14 lines

docs/

ReleaseNotes.rst

4 lines

clang-tidy/

checks/

objc-property-declaration.rst

12 lines

Diff 187128

clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.h

Loading...

clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.cpp

Loading...

clang-tools-extra/trunk/docs/ReleaseNotes.rst

Loading...

clang-tools-extra/trunk/docs/clang-tidy/checks/objc-property-declaration.rst

Loading...