Index: lib/CodeGen/MachineVerifier.cpp =================================================================== --- lib/CodeGen/MachineVerifier.cpp +++ lib/CodeGen/MachineVerifier.cpp @@ -941,9 +941,12 @@ if (isFunctionSelected) report("Unexpected generic instruction in a Selected function", MI); + unsigned NumOps = MI->getNumOperands(); + // Check types. SmallVector Types; - for (unsigned I = 0; I < MCID.getNumOperands(); ++I) { + for (unsigned I = 0, E = std::min(MCID.getNumOperands(), NumOps); + I != E; ++I) { if (!MCID.OpInfo[I].isGenericType()) continue; // Generic instructions specify type equality constraints between some of @@ -974,6 +977,10 @@ if (MO->isReg() && TargetRegisterInfo::isPhysicalRegister(MO->getReg())) report("Generic instruction cannot have physical register", MO, I); } + + // Avoid out of bounds in checks below. This was already reported earlier. + if (MI->getNumOperands() < MCID.getNumOperands()) + return; } StringRef ErrorInfo; @@ -1044,8 +1051,6 @@ // instructions aren't guaranteed to have the right number of operands or // types attached to them at this point assert(MCID.getNumOperands() == 2 && "Expected 2 operands G_*{EXT,TRUNC}"); - if (MI->getNumOperands() < MCID.getNumOperands()) - break; LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); LLT SrcTy = MRI->getType(MI->getOperand(1).getReg()); if (!DstTy.isValid() || !SrcTy.isValid()) Index: test/Verifier/test_g_add.mir =================================================================== --- /dev/null +++ test/Verifier/test_g_add.mir @@ -0,0 +1,28 @@ +#RUN: not llc -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s +# REQUIRES: global-isel, aarch64-registered-target + +--- +name: test_add +legalized: true +regBankSelected: false +selected: false +tracksRegLiveness: true +liveins: +body: | + bb.0: + + %0:_(s32) = G_CONSTANT i32 0 + %1:_(s32) = G_CONSTANT i32 1 + + ; CHECK: Bad machine code: Too few operands + %2:_(s32) = G_ADD + + ; CHECK: Bad machine code: Too few operands + %3:_(s32) = G_ADD %0 + %4:_(s32) = G_ADD %0, %1 + + ; CHECK: Bad machine code: Too few operands + ; CHECK: Bad machine code: Explicit definition marked as use + G_ADD %0, %1 + +... Index: test/Verifier/test_g_constant.mir =================================================================== --- test/Verifier/test_g_constant.mir +++ test/Verifier/test_g_constant.mir @@ -2,7 +2,7 @@ # REQUIRES: global-isel, aarch64-registered-target --- -name: test_constant_vector +name: test_constant legalized: true regBankSelected: false selected: false @@ -12,4 +12,7 @@ bb.0: ; CHECK: Bad machine code: Instruction cannot use a vector result type %0:_(<2 x s32>) = G_CONSTANT i32 0 + + ; CHECK: Bad machine code: Too few operands + %1:_(s32) = G_CONSTANT ... Index: test/Verifier/test_g_trunc.mir =================================================================== --- /dev/null +++ test/Verifier/test_g_trunc.mir @@ -0,0 +1,23 @@ +# RUN: not llc -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s +# REQUIRES: global-isel, aarch64-registered-target + +--- +name: test_trunc +legalized: true +regBankSelected: false +selected: false +tracksRegLiveness: true +liveins: +body: | + bb.0: + + ; CHECK: Bad machine code: Too few operands + %0:_(s32) = G_TRUNC + + %1:_(s64) = G_IMPLICIT_DEF + + ; CHECK: Bad machine code: Too few operands + ; CHECK: Bad machine code: Explicit definition marked as use + G_TRUNC %1 + +...