Index: llvm/test/tools/llvm-objcopy/ELF/binary-output-empty.test =================================================================== --- /dev/null +++ llvm/test/tools/llvm-objcopy/ELF/binary-output-empty.test @@ -0,0 +1,27 @@ +# RUN: yaml2obj %s -o %t.o + +# Writing an empty output to a non-existent file will still create it. +# RUN: rm -f %t-new.txt +# RUN: llvm-objcopy -R .text -O binary %t.o %t-new.txt +# RUN: wc -c %t-new.txt | FileCheck %s + +# Writing an empty output to an existing file will truncate it. +# RUN: echo abcd > %t-existing.txt +# RUN: llvm-objcopy -R .text -O binary %t.o %t-existing.txt +# RUN: wc -c %t-existing.txt | FileCheck %s + +# In both cases, the file should be empty. +# CHECK: 0 + +!ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_EXEC + Machine: EM_X86_64 +Sections: + - Name: .text + Type: SHT_PROGBITS + Flags: [ SHF_ALLOC, SHF_EXECINSTR ] + Content: "c3c3c3c3" + Size: 0x1000 Index: llvm/tools/llvm-objcopy/Buffer.h =================================================================== --- llvm/tools/llvm-objcopy/Buffer.h +++ llvm/tools/llvm-objcopy/Buffer.h @@ -37,6 +37,9 @@ class FileBuffer : public Buffer { std::unique_ptr Buf; + // Indicates that allocate(0) was called, and commit() should create or + // truncate a file instead of using a FileOutputBuffer. + bool EmptyFile = false; public: Error allocate(size_t Size) override; Index: llvm/tools/llvm-objcopy/Buffer.cpp =================================================================== --- llvm/tools/llvm-objcopy/Buffer.cpp +++ llvm/tools/llvm-objcopy/Buffer.cpp @@ -9,7 +9,9 @@ #include "Buffer.h" #include "llvm-objcopy.h" #include "llvm/Support/FileOutputBuffer.h" +#include "llvm/Support/FileSystem.h" #include "llvm/Support/MemoryBuffer.h" +#include "llvm/Support/Process.h" #include namespace llvm { @@ -17,7 +19,31 @@ Buffer::~Buffer() {} +static Error CreateEmptyFile(StringRef FileName) { + // Delete the old file and create a new one to ensure a new file is created on + // disk. + if (sys::fs::exists(FileName)) + if (std::error_code EC = sys::fs::remove(FileName)) + return createFileError(FileName, errorCodeToError(EC)); + + int FD; + if (std::error_code EC = sys::fs::openFileForWrite( + FileName, FD, sys::fs::CD_CreateNew, sys::fs::OF_None)) + return createFileError(FileName, errorCodeToError(EC)); + if (std::error_code EC = sys::Process::SafelyCloseFileDescriptor(FD)) + return createFileError(FileName, errorCodeToError(EC)); + return Error::success(); +} + Error FileBuffer::allocate(size_t Size) { + // When a 0-sized file is requested, skip allocation but defer file + // creation/truncation until commit() to avoid side effects if something + // happens between allocate() and commit(). + if (Size == 0) { + EmptyFile = true; + return Error::success(); + } + Expected> BufferOrErr = FileOutputBuffer::create(getName(), Size, FileOutputBuffer::F_executable); // FileOutputBuffer::create() returns an Error that is just a wrapper around @@ -29,6 +55,10 @@ } Error FileBuffer::commit() { + if (EmptyFile) + return CreateEmptyFile(getName()); + + assert(Buf && "allocate() not called before commit()!"); Error Err = Buf->commit(); // FileOutputBuffer::commit() returns an Error that is just a wrapper around // std::error_code. Wrap it in FileError to include the actual filename.