Index: test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index-gslheader.cpp =================================================================== --- test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index-gslheader.cpp +++ test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index-gslheader.cpp @@ -24,48 +24,48 @@ return base + 3; } -void f(std::array a, int pos) { - a [ pos / 2 /*comment*/] = 1; +void f(std::array list, int pos) { + list [ pos / 2 /*comment*/] = 1; // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use array subscript when the index is not an integer constant expression; use gsl::at() instead [cppcoreguidelines-pro-bounds-constant-array-index] - // CHECK-FIXES: gsl::at(a, pos / 2 /*comment*/) = 1; - int j = a[pos - 1]; + // CHECK-FIXES: gsl::at(list, pos / 2 /*comment*/) = 1; + int j = list[pos - 1]; // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: do not use array subscript when the index is not an integer constant expression; use gsl::at() instead - // CHECK-FIXES: int j = gsl::at(a, pos - 1); + // CHECK-FIXES: int j = gsl::at(list, pos - 1); - a.at(pos-1) = 2; // OK, at() instead of [] - gsl::at(a, pos-1) = 2; // OK, gsl::at() instead of [] + list.at(pos-1) = 2; // OK, at() instead of [] + gsl::at(list, pos-1) = 2; // OK, gsl::at() instead of [] - a[-1] = 3; + list[-1] = 3; // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: std::array<> index -1 is negative [cppcoreguidelines-pro-bounds-constant-array-index] - a[10] = 4; + list[10] = 4; // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: std::array<> index 10 is past the end of the array (which contains 10 elements) [cppcoreguidelines-pro-bounds-constant-array-index] - a[const_index(7)] = 3; + list[const_index(7)] = 3; // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: std::array<> index 10 is past the end of the array (which contains 10 elements) - a[0] = 3; // OK, constant index and inside bounds - a[1] = 3; // OK, constant index and inside bounds - a[9] = 3; // OK, constant index and inside bounds - a[const_index(6)] = 3; // OK, constant index and inside bounds + list[0] = 3; // OK, constant index and inside bounds + list[1] = 3; // OK, constant index and inside bounds + list[9] = 3; // OK, constant index and inside bounds + list[const_index(6)] = 3; // OK, constant index and inside bounds } void g() { int a[10]; for (int i = 0; i < 10; ++i) { - a[i] = i; + list[i] = i; // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use array subscript when the index is not an integer constant expression; use gsl::at() instead - // CHECK-FIXES: gsl::at(a, i) = i; - gsl::at(a, i) = i; // OK, gsl::at() instead of [] + // CHECK-FIXES: gsl::at(list, i) = i; + gsl::at(list, i) = i; // OK, gsl::at() instead of [] } - a[-1] = 3; // flagged by clang-diagnostic-array-bounds - a[10] = 4; // flagged by clang-diagnostic-array-bounds - a[const_index(7)] = 3; // flagged by clang-diagnostic-array-bounds - - a[0] = 3; // OK, constant index and inside bounds - a[1] = 3; // OK, constant index and inside bounds - a[9] = 3; // OK, constant index and inside bounds - a[const_index(6)] = 3; // OK, constant index and inside bounds + list[-1] = 3; // flagged by clang-diagnostic-array-bounds + list[10] = 4; // flagged by clang-diagnostic-array-bounds + list[const_index(7)] = 3; // flagged by clang-diagnostic-array-bounds + + list[0] = 3; // OK, constant index and inside bounds + list[1] = 3; // OK, constant index and inside bounds + list[9] = 3; // OK, constant index and inside bounds + list[const_index(6)] = 3; // OK, constant index and inside bounds } struct S { Index: test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp =================================================================== --- test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp +++ test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp @@ -47,12 +47,12 @@ } void g() { - int a[10]; + int list[10]; for (int i = 0; i < 10; ++i) { - a[i] = i; + list[i] = i; // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use array subscript when the index is not an integer constant expression; use gsl::at() instead - // CHECK-FIXES: gsl::at(a, i) = i; - gsl::at(a, i) = i; // OK, gsl::at() instead of [] + // CHECK-FIXES: gsl::at(list, i) = i; + gsl::at(list, i) = i; // OK, gsl::at() instead of [] } a[-1] = 3; // flagged by clang-diagnostic-array-bounds