Index: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp =================================================================== --- llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp +++ llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp @@ -577,7 +577,7 @@ *CurModule, ArrayTy, false, GlobalVariable::PrivateLinkage, Constant::getNullValue(ArrayTy), "__sancov_gen_"); - if (TargetTriple.supportsCOMDAT()) + if (TargetTriple.supportsCOMDAT() && !F.hasWeakLinkage()) if (auto Comdat = GetOrCreateFunctionComdat(F, TargetTriple, CurModuleUniqueId)) Array->setComdat(Comdat); Index: llvm/test/Instrumentation/SanitizerCoverage/weak-symbol-nocomdat.ll =================================================================== --- /dev/null +++ llvm/test/Instrumentation/SanitizerCoverage/weak-symbol-nocomdat.ll @@ -0,0 +1,17 @@ +; Test that weak functions do not get put in a comdat. +; RUN: opt < %s -sancov -sanitizer-coverage-level=3 -sanitizer-coverage-trace-pc-guard -S | FileCheck %s +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" +; Function Attrs: uwtable +define weak void @Foo() { +entry: + ret void +} + +define void @Bar() { +entry: + ret void +} + +; CHECK-NOT: define weak void @Foo() comdat +; CHECK: define void @Bar() comdat