Page MenuHomePhabricator

[InstCombineAddSub.cpp] Corrected Formatting and Indentation
ClosedPublic

Authored by ankur29.garg on Oct 7 2014, 6:36 AM.

Diff Detail

Event Timeline

ankur29.garg retitled this revision from to [InstCombineAddSub.cpp] Corrected Formatting and Indentation.
ankur29.garg updated this object.
ankur29.garg edited the test plan for this revision. (Show Details)
ankur29.garg added a reviewer: suyog.
ankur29.garg set the repository for this revision to rL LLVM.
ankur29.garg added a subscriber: Unknown Object (MLST).
suyog edited edge metadata.Oct 7 2014, 11:41 PM

Few comments inline.
I would suggest to re-direct it to someone who is more familiar with clang-format.

lib/Transforms/InstCombine/InstCombineAddSub.cpp
1525

Removing this extra space is Ok.

1598

This is Ok.

1601

Not sure if this change is ok. Comment in between confuses things.
clang-format may consider to include extra space.
I would suggest to leave it like as it is.

1606

Not sure if this change is ok. Comment in between confuses things.
clang-format may consider to include extra space.
I would suggest to leave it like as it is, with space padding for '-1'

1613

This is ok.

1633

Not sure if this is Ok.

1640

Not sure if this is Ok.

1704

Not sure if this is ok.

ankur29.garg edited edge metadata.

Made the changes as per your comments. Please review. Thanks.

suyog accepted this revision.Oct 8 2014, 1:40 AM
suyog edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 8 2014, 1:40 AM
suyog added a comment.Oct 8 2014, 1:50 AM

committed in r219286.
Thanks !