Index: test/tools/llvm-objcopy/COFF/strip-all.yaml =================================================================== --- /dev/null +++ test/tools/llvm-objcopy/COFF/strip-all.yaml @@ -0,0 +1,59 @@ +# RUN: yaml2obj %s > %t.in.o + +# RUN: llvm-objdump -t %t.in.o | FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE + +# RUN: llvm-objcopy --strip-all %t.in.o %t.out.o +# RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefix=SYMBOLS +# RUN: llvm-readobj -file-headers -relocs %t.out.o | FileCheck %s --check-prefixes=CHARS,RELOCS + +# Test that -S, llvm-strip without arguments and --strip-out-gnu produces +# identical output. +# RUN: llvm-objcopy -S %t.in.o %t.out-short.o +# RUN: cmp %t.out.o %t.out-short.o + +# RUN: cp %t.in.o %t.out-strip.o +# RUN: llvm-strip %t.out-strip.o +# RUN: cmp %t.out.o %t.out-strip.o + +# RUN: llvm-objcopy --strip-all-gnu %t.in.o %t.out-gnu.o +# RUN: cmp %t.out.o %t.out-gnu.o + +# SYMBOLS: SYMBOL TABLE: +# SYMBOLS-PRE-NEXT: external +# SYMBOLS-PRE-NEXT: external_undefined +# SYMBOLS-EMPTY: + +# CHARS: Characteristics [ +# CHARS-NEXT: IMAGE_FILE_RELOCS_STRIPPED +# CHARS-NEXT: ] + +# RELOCS: Relocations [ +# RELOCS-NEXT: ] + +--- !COFF +header: + Machine: IMAGE_FILE_MACHINE_AMD64 + Characteristics: [ ] +sections: + - Name: .text + Characteristics: [ ] + Alignment: 4 + SectionData: 488B0500000000C3 + Relocations: + - VirtualAddress: 3 + SymbolName: external_undefined + Type: IMAGE_REL_AMD64_REL32 +symbols: + - Name: external + Value: 0 + SectionNumber: 1 + SimpleType: IMAGE_SYM_TYPE_NULL + ComplexType: IMAGE_SYM_DTYPE_NULL + StorageClass: IMAGE_SYM_CLASS_EXTERNAL + - Name: external_undefined + Value: 0 + SectionNumber: 0 + SimpleType: IMAGE_SYM_TYPE_NULL + ComplexType: IMAGE_SYM_DTYPE_NULL + StorageClass: IMAGE_SYM_CLASS_EXTERNAL +... Index: tools/llvm-objcopy/COFF/COFFObjcopy.cpp =================================================================== --- tools/llvm-objcopy/COFF/COFFObjcopy.cpp +++ tools/llvm-objcopy/COFF/COFFObjcopy.cpp @@ -28,6 +28,22 @@ using namespace COFF; static Error handleArgs(const CopyConfig &Config, Object &Obj) { + // StripAll removes all symbols and thus also removes all relocations. + if (Config.StripAll || Config.StripAllGNU) { + for (Section &Sec : Obj.Sections) + Sec.Relocs.clear(); + // The description of IMAGE_FILE_RELOCS_STRIPPED only talks about its + // role on executables, where it would indicate absence of base relocs, + // which are a different thing than the normal COFF relocs (which only + // are used in object files). GNU objcopy sets this flag, and it's + // probably useful to indicate that the object file is severely + // broken by this operation. + Obj.CoffFileHeader.Characteristics |= IMAGE_FILE_RELOCS_STRIPPED; + // GNU objcopy also sets IMAGE_FILE_LOCAL_SYMS_STRIPPED + // (and IMAGE_FILE_LINE_NUMS_STRIPPED), but there's less point in setting + // those. + } + // If we need to do per-symbol removals, initialize the Referenced field. if (Config.StripUnneeded || Config.DiscardAll || !Config.SymbolsToRemove.empty()) @@ -36,6 +52,11 @@ // Actually do removals of symbols. Obj.removeSymbols([&](const Symbol &Sym) { + // For StripAll, all relocations have been stripped and we remove all + // symbols. + if (Config.StripAll || Config.StripAllGNU) + return true; + if (is_contained(Config.SymbolsToRemove, Sym.Name)) { // Explicitly removing a referenced symbol is an error. if (Sym.Referenced) Index: tools/llvm-objcopy/COFF/Writer.cpp =================================================================== --- tools/llvm-objcopy/COFF/Writer.cpp +++ tools/llvm-objcopy/COFF/Writer.cpp @@ -48,8 +48,11 @@ S.Header.PointerToRawData = FileSize; FileSize += S.Header.SizeOfRawData; // For executables, this is already // aligned to FileAlignment. + S.Header.NumberOfRelocations = S.Relocs.size(); if (S.Header.NumberOfRelocations > 0) S.Header.PointerToRelocations = FileSize; + else + S.Header.PointerToRelocations = 0; FileSize += S.Relocs.size() * sizeof(coff_relocation); FileSize = alignTo(FileSize, FileAlignment);