This is an archive of the discontinued LLVM Phabricator instance.

[Nios2] Update overrides to new virtual method signatures
AcceptedPublic

Authored by cag on Dec 31 2018, 12:07 PM.

Details

Reviewers
craig.topper
Summary

Enabling Nios2 as an experimental target causes build to break because the overridden methods in Nios2AsmBackend do not have signatures matching the new ones in MCAsmBackend. This patch addresses that.

Diff Detail

Event Timeline

cag created this revision.Dec 31 2018, 12:07 PM
craig.topper added inline comments.
lib/Target/Nios2/MCTargetDesc/Nios2AsmBackend.h
43–44

Is this line longer than 80 characters? If so please wrap it.

59

Please wrap this line to 80 characters or less.

cag updated this revision to Diff 180176.Jan 3 2019, 4:30 PM

Wrapped lines at 80 characters

This revision is now accepted and ready to land.Jan 3 2019, 4:32 PM

Do you need me to commit this?

On second thought. I'm proposing we just nuke this backend all together.