Page MenuHomePhabricator

[MSan] Handle llvm.is.constant intrinsic
AcceptedPublic

Authored by glider on Dec 30 2018, 4:42 AM.

Details

Reviewers
dvyukov
eugenis
Summary

MSan used to report false positives in the case the argument of llvm.is.constant intrinsic was uninitialized.
In fact checking this argument is unnecessary, as the intrinsic is only used at compile time, and its value doesn't depend on the value of the argument.

Diff Detail

Event Timeline

glider created this revision.Dec 30 2018, 4:42 AM
dvyukov accepted this revision.Dec 30 2018, 6:03 AM

Nice! Interesting nobody reported this false positive on user-space code.

This revision is now accepted and ready to land.Dec 30 2018, 6:03 AM

Landed r350173, thank you!