Index: lib/Target/AArch64/AArch64InstrInfo.cpp =================================================================== --- lib/Target/AArch64/AArch64InstrInfo.cpp +++ lib/Target/AArch64/AArch64InstrInfo.cpp @@ -4746,7 +4746,8 @@ static const std::pair TargetFlags[] = { {MO_COFFSTUB, "aarch64-coffstub"}, {MO_GOT, "aarch64-got"}, {MO_NC, "aarch64-nc"}, - {MO_TLS, "aarch64-tls"}, {MO_DLLIMPORT, "aarch64-dllimport"}}; + {MO_S, "aarch64-s"}, {MO_TLS, "aarch64-tls"}, + {MO_DLLIMPORT, "aarch64-dllimport"}}; return makeArrayRef(TargetFlags); } Index: lib/Target/AArch64/AArch64MCInstLower.cpp =================================================================== --- lib/Target/AArch64/AArch64MCInstLower.cpp +++ lib/Target/AArch64/AArch64MCInstLower.cpp @@ -189,20 +189,49 @@ MCOperand AArch64MCInstLower::lowerSymbolOperandCOFF(const MachineOperand &MO, MCSymbol *Sym) const { - AArch64MCExpr::VariantKind RefKind = AArch64MCExpr::VK_NONE; + uint32_t RefFlags = 0; + if (MO.getTargetFlags() & AArch64II::MO_TLS) { if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_PAGEOFF) - RefKind = AArch64MCExpr::VK_SECREL_LO12; + RefFlags |= AArch64MCExpr::VK_SECREL_LO12; else if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_HI12) - RefKind = AArch64MCExpr::VK_SECREL_HI12; + RefFlags |= AArch64MCExpr::VK_SECREL_HI12; + + } else if (MO.getTargetFlags() & AArch64II::MO_S) + RefFlags |= AArch64MCExpr::VK_SABS; + else RefFlags |= AArch64MCExpr::VK_ABS; + + if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_G3) + RefFlags |= AArch64MCExpr::VK_G3; + else if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_G2) + RefFlags |= AArch64MCExpr::VK_G2; + else if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_G1) + RefFlags |= AArch64MCExpr::VK_G1; + else if ((MO.getTargetFlags() & AArch64II::MO_FRAGMENT) == AArch64II::MO_G0) + RefFlags |= AArch64MCExpr::VK_G0; + + // FIXME: Currently we only set VK_NC for MO_G3/MO_G2/MO_G1/MO_G0. This is + // because setting VK_NC for others would mean setting their respective + // RefFlags correctly. We should do this in a separate patch. + if (MO.getTargetFlags() & AArch64II::MO_NC) { + auto MOFrag = (MO.getTargetFlags() & AArch64II::MO_FRAGMENT); + if (MOFrag == AArch64II::MO_G3 || MOFrag == AArch64II::MO_G2 || + MOFrag == AArch64II::MO_G1 || MOFrag == AArch64II::MO_G0) + RefFlags |= AArch64MCExpr::VK_NC; } + const MCExpr *Expr = MCSymbolRefExpr::create(Sym, MCSymbolRefExpr::VK_None, Ctx); if (!MO.isJTI() && MO.getOffset()) Expr = MCBinaryExpr::createAdd( Expr, MCConstantExpr::create(MO.getOffset(), Ctx), Ctx); + + auto RefKind = static_cast(RefFlags); + assert(RefKind != AArch64MCExpr::VK_INVALID && + "Invalid relocation requested"); Expr = AArch64MCExpr::create(Expr, RefKind, Ctx); + return MCOperand::createExpr(Expr); } Index: lib/Target/AArch64/Utils/AArch64BaseInfo.h =================================================================== --- lib/Target/AArch64/Utils/AArch64BaseInfo.h +++ lib/Target/AArch64/Utils/AArch64BaseInfo.h @@ -581,6 +581,10 @@ /// to the symbol is for an import stub. This is used for DLL import /// storage class indication on Windows. MO_DLLIMPORT = 0x80, + + /// MO_S - Indicates that the bits of the symbol operand represented by + /// MO_G0 etc are signed. + MO_S = 0x100, }; } // end namespace AArch64II Index: test/CodeGen/AArch64/reloc-specifiers.mir =================================================================== --- /dev/null +++ test/CodeGen/AArch64/reloc-specifiers.mir @@ -0,0 +1,21 @@ +# RUN: llc -mtriple=arm64-windows -start-after=prologepilog -show-mc-encoding \ +# RUN: -o - %s | FileCheck %s + +--- | + define void @bar() { ret void } +... + +--- +name: bar +body: | + bb.0: + ; CHECK-LABEL: bar + + ; CHECK: movz x0, #:abs_g1_s:.Lfoo$frame_escape_0 ; encoding: [0bAAA00000,A,0b101AAAAA,0xd2] + ; CHECK: fixup A - offset: 0, value: :abs_g1_s:.Lfoo$frame_escape_0, kind: fixup_aarch64_movw + renamable $x0 = MOVZXi target-flags(aarch64-g1, aarch64-s) , 16 + + ; CHECK: movk x0, #:abs_g0_nc:.Lfoo$frame_escape_0 ; encoding: [0bAAA00000,A,0b100AAAAA,0xf2] + ; CHECK: fixup A - offset: 0, value: :abs_g0_nc:.Lfoo$frame_escape_0, kind: fixup_aarch64_movw + renamable $x0 = MOVKXi $x0, target-flags(aarch64-g0, aarch64-nc) , 0 +...