Index: llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp =================================================================== --- llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp +++ llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp @@ -244,6 +244,14 @@ return NewMul; } + // -X * Y --> -(X * Y) + if (match(Op0, m_OneUse(m_Neg(m_Value(X))))) + return BinaryOperator::CreateNeg(Builder.CreateMul(X, Op1)); + + // X * -Y --> -(X * Y) + if (match(Op1, m_OneUse(m_Neg(m_Value(Y))))) + return BinaryOperator::CreateNeg(Builder.CreateMul(Op0, Y)); + // (X / Y) * Y = X - (X % Y) // (X / Y) * -Y = (X % Y) - X { Index: llvm/test/Transforms/InstCombine/mul.ll =================================================================== --- llvm/test/Transforms/InstCombine/mul.ll +++ llvm/test/Transforms/InstCombine/mul.ll @@ -445,31 +445,33 @@ define i32 @test_mul_canonicalize_op0(i32 %x, i32 %y) { ; CHECK-LABEL: @test_mul_canonicalize_op0( -; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[X:%.*]] -; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[NEG]], [[Y:%.*]] -; CHECK-NEXT: ret i32 [[MUL]] +; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[X:%.*]], [[Y:%.*]] +; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[MUL]] +; CHECK-NEXT: ret i32 [[NEG]] ; %neg = sub i32 0, %x %mul = mul i32 %neg, %y ret i32 %mul } -define i32 @test_mul_canonicalize_op1(i32 %x, i32 %y) { +define i32 @test_mul_canonicalize_op1(i32 %x, i32 %z) { ; CHECK-LABEL: @test_mul_canonicalize_op1( -; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[Y:%.*]] -; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[NEG]], [[X:%.*]] -; CHECK-NEXT: ret i32 [[MUL]] +; CHECK-NEXT: [[Y:%.*]] = mul i32 [[Z:%.*]], 3 +; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[X:%.*]], [[Y:%.*]] +; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[MUL]] +; CHECK-NEXT: ret i32 [[NEG]] ; - %neg = sub i32 0, %y - %mul = mul i32 %x, %neg + %y = mul i32 %z, 3 + %neg = sub i32 0, %x + %mul = mul i32 %y, %neg ret i32 %mul } define i32 @test_mul_canonicalize_nsw(i32 %x, i32 %y) { ; CHECK-LABEL: @test_mul_canonicalize_nsw( -; CHECK-NEXT: [[NEG:%.*]] = sub nsw i32 0, [[X:%.*]] -; CHECK-NEXT: [[MUL:%.*]] = mul nsw i32 [[NEG]], [[Y:%.*]] -; CHECK-NEXT: ret i32 [[MUL]] +; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[X:%.*]], [[Y:%.*]] +; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[MUL]] +; CHECK-NEXT: ret i32 [[NEG]] ; %neg = sub nsw i32 0, %x %mul = mul nsw i32 %neg, %y @@ -478,11 +480,24 @@ define <2 x i32> @test_mul_canonicalize_vec(<2 x i32> %x, <2 x i32> %y) { ; CHECK-LABEL: @test_mul_canonicalize_vec( -; CHECK-NEXT: [[NEG:%.*]] = sub <2 x i32> zeroinitializer, [[X:%.*]] -; CHECK-NEXT: [[MUL:%.*]] = mul <2 x i32> [[NEG]], [[Y:%.*]] -; CHECK-NEXT: ret <2 x i32> [[MUL]] +; CHECK-NEXT: [[MUL:%.*]] = mul <2 x i32> [[X:%.*]], [[Y:%.*]] +; CHECK-NEXT: [[NEG:%.*]] = sub <2 x i32> zeroinitializer, [[MUL]] +; CHECK-NEXT: ret <2 x i32> [[NEG]] ; %neg = sub <2 x i32> , %x %mul = mul <2 x i32> %neg, %y ret <2 x i32> %mul } + +define i32 @test_mul_canonicalize_multiple_uses(i32 %x, i32 %y) { +; CHECK-LABEL: @test_mul_canonicalize_multiple_uses( +; CHECK-NEXT: [[NEG:%.*]] = sub i32 0, [[X:%.*]] +; CHECK-NEXT: [[MUL:%.*]] = mul i32 [[NEG]], [[Y:%.*]] +; CHECK-NEXT: [[MUL2:%.*]] = mul i32 [[MUL]], [[NEG]] +; CHECK-NEXT: ret i32 [[MUL2]] +; + %neg = sub i32 0, %x + %mul = mul i32 %neg, %y + %mul2 = mul i32 %mul, %neg + ret i32 %mul2 +} Index: llvm/test/Transforms/InstCombine/operand-complexity.ll =================================================================== --- llvm/test/Transforms/InstCombine/operand-complexity.ll +++ llvm/test/Transforms/InstCombine/operand-complexity.ll @@ -6,9 +6,9 @@ define i8 @neg(i8 %x) { ; CHECK-LABEL: @neg( ; CHECK-NEXT: [[BO:%.*]] = udiv i8 [[X:%.*]], 42 -; CHECK-NEXT: [[NEGX:%.*]] = sub i8 0, [[X]] -; CHECK-NEXT: [[R:%.*]] = mul i8 [[BO]], [[NEGX]] -; CHECK-NEXT: ret i8 [[R]] +; CHECK-NEXT: [[R:%.*]] = mul i8 [[BO]], [[X]] +; CHECK-NEXT: [[NEGX:%.*]] = sub i8 0, [[R]] +; CHECK-NEXT: ret i8 [[NEGX]] ; %bo = udiv i8 %x, 42 %negx = sub i8 0, %x @@ -19,9 +19,9 @@ define <2 x i8> @neg_vec(<2 x i8> %x) { ; CHECK-LABEL: @neg_vec( ; CHECK-NEXT: [[BO:%.*]] = udiv <2 x i8> [[X:%.*]], -; CHECK-NEXT: [[NEGX:%.*]] = sub <2 x i8> zeroinitializer, [[X]] -; CHECK-NEXT: [[R:%.*]] = mul <2 x i8> [[BO]], [[NEGX]] -; CHECK-NEXT: ret <2 x i8> [[R]] +; CHECK-NEXT: [[R:%.*]] = mul <2 x i8> [[BO]], [[X]] +; CHECK-NEXT: [[NEGX:%.*]] = sub <2 x i8> zeroinitializer, [[R]] +; CHECK-NEXT: ret <2 x i8> [[NEGX]] ; %bo = udiv <2 x i8> %x, %negx = sub <2 x i8> , %x @@ -32,9 +32,9 @@ define <2 x i8> @neg_vec_undef(<2 x i8> %x) { ; CHECK-LABEL: @neg_vec_undef( ; CHECK-NEXT: [[BO:%.*]] = udiv <2 x i8> [[X:%.*]], -; CHECK-NEXT: [[NEGX:%.*]] = sub <2 x i8> , [[X]] -; CHECK-NEXT: [[R:%.*]] = mul <2 x i8> [[BO]], [[NEGX]] -; CHECK-NEXT: ret <2 x i8> [[R]] +; CHECK-NEXT: [[R:%.*]] = mul <2 x i8> [[BO]], [[X]] +; CHECK-NEXT: [[NEGX:%.*]] = sub <2 x i8> zeroinitializer, [[R]] +; CHECK-NEXT: ret <2 x i8> [[NEGX]] ; %bo = udiv <2 x i8> %x, %negx = sub <2 x i8> , %x