Index: cfe/trunk/include/clang/Tooling/Tooling.h =================================================================== --- cfe/trunk/include/clang/Tooling/Tooling.h +++ cfe/trunk/include/clang/Tooling/Tooling.h @@ -205,7 +205,7 @@ /// /// \return The resulting AST or null if an error occurred. std::unique_ptr -buildASTFromCode(const Twine &Code, const Twine &FileName = "input.cc", +buildASTFromCode(StringRef Code, StringRef FileName = "input.cc", std::shared_ptr PCHContainerOps = std::make_shared()); @@ -223,10 +223,10 @@ /// /// \return The resulting AST or null if an error occurred. std::unique_ptr buildASTFromCodeWithArgs( - const Twine &Code, const std::vector &Args, - const Twine &FileName = "input.cc", const Twine &ToolName = "clang-tool", + StringRef Code, const std::vector &Args, + StringRef FileName = "input.cc", StringRef ToolName = "clang-tool", std::shared_ptr PCHContainerOps = - std::make_shared(), + std::make_shared(), ArgumentsAdjuster Adjuster = getClangStripDependencyFileAdjuster()); /// Utility to run a FrontendAction in a single clang invocation. Index: cfe/trunk/lib/Tooling/Tooling.cpp =================================================================== --- cfe/trunk/lib/Tooling/Tooling.cpp +++ cfe/trunk/lib/Tooling/Tooling.cpp @@ -574,20 +574,16 @@ namespace tooling { std::unique_ptr -buildASTFromCode(const Twine &Code, const Twine &FileName, +buildASTFromCode(StringRef Code, StringRef FileName, std::shared_ptr PCHContainerOps) { return buildASTFromCodeWithArgs(Code, std::vector(), FileName, "clang-tool", std::move(PCHContainerOps)); } std::unique_ptr buildASTFromCodeWithArgs( - const Twine &Code, const std::vector &Args, - const Twine &FileName, const Twine &ToolName, - std::shared_ptr PCHContainerOps, + StringRef Code, const std::vector &Args, StringRef FileName, + StringRef ToolName, std::shared_ptr PCHContainerOps, ArgumentsAdjuster Adjuster) { - SmallString<16> FileNameStorage; - StringRef FileNameRef = FileName.toNullTerminatedStringRef(FileNameStorage); - std::vector> ASTs; ASTBuilderAction Action(ASTs); llvm::IntrusiveRefCntPtr OverlayFileSystem( @@ -599,13 +595,11 @@ new FileManager(FileSystemOptions(), OverlayFileSystem)); ToolInvocation Invocation( - getSyntaxOnlyToolArgs(ToolName, Adjuster(Args, FileNameRef), FileNameRef), + getSyntaxOnlyToolArgs(ToolName, Adjuster(Args, FileName), FileName), &Action, Files.get(), std::move(PCHContainerOps)); - SmallString<1024> CodeStorage; - InMemoryFileSystem->addFile(FileNameRef, 0, - llvm::MemoryBuffer::getMemBuffer( - Code.toNullTerminatedStringRef(CodeStorage))); + InMemoryFileSystem->addFile(FileName, 0, + llvm::MemoryBuffer::getMemBufferCopy(Code)); if (!Invocation.run()) return nullptr; Index: cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp =================================================================== --- cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp +++ cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp @@ -11,6 +11,7 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/ASTMatchers/ASTMatchers.h" #include "clang/Tooling/Tooling.h" +#include "llvm/ADT/SmallString.h" #include "gmock/gmock.h" #include "gtest/gtest.h" #include @@ -32,7 +33,9 @@ std::unique_ptr buildASTFromCodeWithArgs(const Twine &Code, const std::vector &Args) { - auto AST = tooling::buildASTFromCodeWithArgs(Code, Args); + SmallString<1024> CodeStorage; + auto AST = + tooling::buildASTFromCodeWithArgs(Code.toStringRef(CodeStorage), Args); EXPECT_FALSE(AST->getDiagnostics().hasErrorOccurred()); return AST; }