Index: lib/CodeGen/TargetInfo.cpp =================================================================== --- lib/CodeGen/TargetInfo.cpp +++ lib/CodeGen/TargetInfo.cpp @@ -1695,10 +1695,25 @@ } if (Ty->isMemberPointerType()) { - if (Ty->isMemberFunctionPointerType() && Has64BitPointers) - Lo = Hi = Integer; - else + if (Ty->isMemberFunctionPointerType()) { + if (Has64BitPointers) { + // If Has64BitPointers, this is an {i64, i64}, so classify both + // Lo and Hi now. + Lo = Hi = Integer; + } else { + // Otherwise, with 32-bit pointers, this is an {i32, i32}. If that + // straddles an eightbyte boundary, Hi should be classified as well. + uint64_t EB_FuncPtr = (OffsetBase) / 64; + uint64_t EB_ThisAdj = (OffsetBase + 64 - 1) / 64; + if (EB_FuncPtr != EB_ThisAdj) { + Lo = Hi = Integer; + } else { + Current = Integer; + } + } + } else { Current = Integer; + } return; } Index: test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp =================================================================== --- /dev/null +++ test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp @@ -0,0 +1,42 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-nacl -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple=x86_64-unknown-linux-gnux32 -emit-llvm -o - %s | FileCheck %s + +struct s4 {}; +typedef int s4::* s4_mdp; +typedef int (s4::*s4_mfp)(); + +// CHECK-LABEL: define i32 @{{.*}}f_mdp{{.*}}(i32 %a) +s4_mdp f_mdp(s4_mdp a) { return a; } + +// CHECK-LABEL: define {{.*}} @{{.*}}f_mfp{{.*}}(i64 %a.coerce) +s4_mfp f_mfp(s4_mfp a) { return a; } + +// A struct with <= 12 bytes before a member data pointer should still +// be allowed in registers, since the member data pointer is only 4 bytes. +// CHECK-LABEL: define void @{{.*}}f_struct_with_mdp{{.*}}(i64 %a.coerce0, i64 %a.coerce1) +struct struct_with_mdp { char *a; char *b; char *c; s4_mdp d; }; +void f_struct_with_mdp(struct_with_mdp a) { (void)a; } + +struct struct_with_mdp_too_much { + char *a; char *b; char *c; char *d; s4_mdp e; +}; +// CHECK-LABEL: define void @{{.*}}f_struct_with_mdp_too_much{{.*}}({{.*}} byval {{.*}} %a) +void f_struct_with_mdp_too_much(struct_with_mdp_too_much a) { + (void)a; +} + +// A struct with <= 8 bytes before a member function pointer should still +// be allowed in registers, since the member function pointer is only 8 bytes. +// CHECK-LABEL: define void @{{.*}}f_struct_with_mfp_0{{.*}}(i64 %a.coerce0, i32 %a.coerce1) +struct struct_with_mfp_0 { char *a; s4_mfp b; }; +void f_struct_with_mfp_0(struct_with_mfp_0 a) { (void)a; } + +// CHECK-LABEL: define void @{{.*}}f_struct_with_mfp_1{{.*}}(i64 %a.coerce0, i64 %a.coerce1) +struct struct_with_mfp_1 { char *a; char *b; s4_mfp c; }; +void f_struct_with_mfp_1(struct_with_mfp_1 a) { (void)a; } + +// CHECK-LABEL: define void @{{.*}}f_struct_with_mfp_too_much{{.*}}({{.*}} byval {{.*}} %a, i32 %x) +struct struct_with_mfp_too_much { char *a; char *b; char *c; s4_mfp d; }; +void f_struct_with_mfp_too_much(struct_with_mfp_too_much a, int x) { + (void)a; +} Index: test/CodeGenCXX/x86_64-arguments.cpp =================================================================== --- test/CodeGenCXX/x86_64-arguments.cpp +++ test/CodeGenCXX/x86_64-arguments.cpp @@ -32,6 +32,21 @@ s4_mdp f4_0(s4_mdp a) { return a; } s4_mfp f4_1(s4_mfp a) { return a; } +// A struct with <= one eightbyte before a member data pointer should still +// be allowed in registers. +// CHECK-LABEL: define void @{{.*}}f_struct_with_mdp{{.*}}(i8* %a.coerce0, i64 %a.coerce1) +struct struct_with_mdp { char *a; s4_mdp b; }; +void f_struct_with_mdp(struct_with_mdp a) { (void)a; } + +// A struct with anything before a member function will be too big and +// goes in memory. +// CHECK-LABEL: define void @{{.*}}f_struct_with_mfp_0{{.*}}(%struct{{.*}} byval align 8 %a) +struct struct_with_mfp_0 { char a; s4_mfp b; }; +void f_struct_with_mfp_0(struct_with_mfp_0 a) { (void)a; } + +// CHECK-LABEL: define void @{{.*}}f_struct_with_mfp_1{{.*}}(%struct{{.*}} byval align 8 %a) +struct struct_with_mfp_1 { void *a; s4_mfp b; }; +void f_struct_with_mfp_1(struct_with_mfp_1 a) { (void)a; } namespace PR7523 { struct StringRef {