This is an archive of the discontinued LLVM Phabricator instance.

Differential D55551

Only warn about double promotion when in a live path
AbandonedPublic

Authored by serge-sans-paille on Dec 11 2018, 2:48 AM.

Details

Reviewers
george.burgess.iv
tstellar

Diff Detail

Event Timeline

serge-sans-paille created this revision.Dec 11 2018, 2:48 AM

This should fix https://bugs.llvm.org/show_bug.cgi?id=39938

serge-sans-paille added a reviewer: tstellar.Dec 11 2018, 2:49 AM
serge-sans-paille abandoned this revision.Dec 11 2018, 11:42 PM

As discussed in https://bugs.llvm.org/show_bug.cgi?id=39938, this is consistent with other warning of that class, so let it stay like that.

Revision Contents

PathSize
lib/
Sema/
2 lines

Diff 177677

lib/Sema/SemaChecking.cpp

Context not available.
if (S.SourceMgr.isInSystemMacro(CC)) if (S.SourceMgr.isInSystemMacro(CC))
return; return;
DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_double_promotion); DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_double_promotion, true);
} }
return; return;
} }
Context not available.