Page MenuHomePhabricator

WinCOFFObjectWriter: optimize the string table for common suffices
ClosedPublic

Authored by hans on Sep 29 2014, 12:50 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 14173.Sep 29 2014, 12:50 PM
hans retitled this revision from to WinCOFFObjectWriter: optimize the string table for common suffices.
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added a reviewer: majnemer.
hans added subscribers: Unknown Object (MLST), hansw.
majnemer accepted this revision.Sep 29 2014, 1:18 PM
majnemer edited edge metadata.

LGTM

lib/MC/StringTableBuilder.cpp
31 ↗(On Diff #14173)

Can we reserve space for StringIndexMap.size() number of StringRefs?

This revision is now accepted and ready to land.Sep 29 2014, 1:18 PM
hans added inline comments.Sep 29 2014, 3:53 PM
lib/MC/StringTableBuilder.cpp
31 ↗(On Diff #14173)

Done.

hans closed this revision.Sep 29 2014, 3:53 PM
hans updated this revision to Diff 14194.

Closed by commit rL218636 (authored by @hans).