diff --git a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp --- a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp @@ -1431,7 +1431,8 @@ void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const { - + // This will regard deleting freed() regions as a use-after-free, rather then + // a double-free or double-delete error. if (!ChecksEnabled[CK_NewDeleteChecker]) if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol()) checkUseAfterFree(Sym, C, DE->getArgument()); @@ -1628,7 +1629,8 @@ } /// Checks if the previous call to free on the given symbol failed - if free -/// failed, returns true. Also, returns the corresponding return value symbol. +/// failed, returns true. Also, stores the corresponding return value symbol in +/// \p RetStatusSymbol. static bool didPreviousFreeFail(ProgramStateRef State, SymbolRef Sym, SymbolRef &RetStatusSymbol) { const SymbolRef *Ret = State->get(Sym); @@ -2289,6 +2291,12 @@ if (!CheckKind.hasValue()) return; + // If this is a double delete error, print the appropiate warning message. + if (CheckKind == CK_NewDeleteChecker) { + ReportDoubleDelete(C, Sym); + return; + } + if (ExplodedNode *N = C.generateErrorNode()) { if (!BT_DoubleFree[*CheckKind]) BT_DoubleFree[*CheckKind].reset(new BugType( diff --git a/clang/test/Analysis/Inputs/expected-plists/NewDelete-path-notes.cpp.plist b/clang/test/Analysis/Inputs/expected-plists/NewDelete-path-notes.cpp.plist --- a/clang/test/Analysis/Inputs/expected-plists/NewDelete-path-notes.cpp.plist +++ b/clang/test/Analysis/Inputs/expected-plists/NewDelete-path-notes.cpp.plist @@ -194,17 +194,17 @@ depth0 extended_message - Attempt to free released memory + Attempt to delete released memory message - Attempt to free released memory + Attempt to delete released memory - descriptionAttempt to free released memory + descriptionAttempt to delete released memory categoryMemory error - typeDouble free + typeDouble delete check_namecplusplus.NewDelete - issue_hash_content_of_line_in_contextbd8e324d09c70b9e2be6f824a4942e5a + issue_hash_content_of_line_in_context593b185245106bed5175ccf2753039b2 issue_context_kindfunction issue_contexttest issue_hash_function_offset8 @@ -423,17 +423,17 @@ depth0 extended_message - Attempt to free released memory + Attempt to delete released memory message - Attempt to free released memory + Attempt to delete released memory - descriptionAttempt to free released memory + descriptionAttempt to delete released memory categoryMemory error - typeDouble free + typeDouble delete check_namecplusplus.NewDelete - issue_hash_content_of_line_in_context8bf1a5b9fdae9d86780aa6c4cdce2605 + issue_hash_content_of_line_in_context6484e9b006ede7362edef2187ba6eb37 issue_context_kindfunction issue_contexttest issue_hash_function_offset3 diff --git a/clang/test/Analysis/Malloc+MismatchedDeallocator+NewDelete.cpp b/clang/test/Analysis/Malloc+MismatchedDeallocator+NewDelete.cpp --- a/clang/test/Analysis/Malloc+MismatchedDeallocator+NewDelete.cpp +++ b/clang/test/Analysis/Malloc+MismatchedDeallocator+NewDelete.cpp @@ -46,7 +46,7 @@ void testNewDoubleFree() { int *p = new int; delete p; - delete p; // expected-warning{{Attempt to free released memory}} + delete p; // expected-warning{{Attempt to delete released memory}} } void testNewLeak() { diff --git a/clang/test/Analysis/NewDelete-checker-test.cpp b/clang/test/Analysis/NewDelete-checker-test.cpp --- a/clang/test/Analysis/NewDelete-checker-test.cpp +++ b/clang/test/Analysis/NewDelete-checker-test.cpp @@ -182,7 +182,7 @@ void testDoubleDelete() { int *p = new int; delete p; - delete p; // expected-warning{{Attempt to free released memory}} + delete p; // expected-warning{{Attempt to delete released memory}} } void testExprDeleteArg() { diff --git a/clang/test/Analysis/NewDelete-path-notes.cpp b/clang/test/Analysis/NewDelete-path-notes.cpp --- a/clang/test/Analysis/NewDelete-path-notes.cpp +++ b/clang/test/Analysis/NewDelete-path-notes.cpp @@ -11,8 +11,8 @@ delete p; // expected-note@-1 {{Memory is released}} - delete p; // expected-warning {{Attempt to free released memory}} - // expected-note@-1 {{Attempt to free released memory}} + delete p; // expected-warning {{Attempt to delete released memory}} + // expected-note@-1 {{Attempt to delete released memory}} } struct Odd { @@ -24,7 +24,7 @@ void test(Odd *odd) { odd->kill(); // expected-note{{Calling 'Odd::kill'}} // expected-note@-1 {{Returning; memory was released}} - delete odd; // expected-warning {{Attempt to free released memory}} - // expected-note@-1 {{Attempt to free released memory}} + delete odd; // expected-warning {{Attempt to delete released memory}} + // expected-note@-1 {{Attempt to delete released memory}} } diff --git a/clang/test/Analysis/dtor.cpp b/clang/test/Analysis/dtor.cpp --- a/clang/test/Analysis/dtor.cpp +++ b/clang/test/Analysis/dtor.cpp @@ -528,7 +528,7 @@ return *this; } ~NonTrivial() { - delete[] p; // expected-warning {{free released memory}} + delete[] p; // expected-warning {{delete released memory}} } };