Index: ELF/Writer.cpp =================================================================== --- ELF/Writer.cpp +++ ELF/Writer.cpp @@ -168,9 +168,10 @@ static Defined *addOptionalRegular(StringRef Name, SectionBase *Sec, uint64_t Val, uint8_t StOther = STV_HIDDEN, - uint8_t Binding = STB_GLOBAL) { + uint8_t Binding = STB_GLOBAL, + bool AllowMuldef = true) { Symbol *S = Symtab->find(Name); - if (!S || S->isDefined()) + if (!S || (AllowMuldef && S->isDefined())) return nullptr; Symbol *Sym = Symtab->addDefined(Name, StOther, STT_NOTYPE, Val, /*Size=*/0, Binding, Sec, @@ -213,9 +214,12 @@ // _GLOBAL_OFFSET_TABLE_ and _SDA_BASE_ from the 32-bit ABI. It is used to // represent the TOC base which is offset by 0x8000 bytes from the start of // the .got section. + // We do not _GLOBAL_OFFSET_TABLE_ to be defined by input objects as the + // correctness of some relocations depends on its value. ElfSym::GlobalOffsetTable = addOptionalRegular( (Config->EMachine == EM_PPC64) ? ".TOC." : "_GLOBAL_OFFSET_TABLE_", - Out::ElfHeader, Target->GotBaseSymOff); + Out::ElfHeader, Target->GotBaseSymOff, STV_HIDDEN, STB_GLOBAL, + /*AllowMulDef*/ false); // __ehdr_start is the location of ELF file headers. Note that we define // this symbol unconditionally even when using a linker script, which Index: test/ELF/global-offset-table-position-redef-err.s =================================================================== --- /dev/null +++ test/ELF/global-offset-table-position-redef-err.s @@ -0,0 +1,13 @@ +# REQUIRES x86 +# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o +# RUN: not ld.lld -shared %t.o -o %t.so 2>&1 | FileCheck %s + +# On some targets the location of the _GLOBAL_OFFSET_TABLE_ symbol table can +# matter for the correctness of some relocations. Follow the example of ld.gold +# and give a multiple definition error if input objects attempt to redefine it. + +# CHECK: ld.lld: error: duplicate symbol: _GLOBAL_OFFSET_TABLE_ +.data +.global _GLOBAL_OFFSET_TABLE_ +_GLOBAL_OFFSET_TABLE_: +.word 0