I have confidence in this change, can I commit this directly?
Details
Diff Detail
Event Timeline
If anything, the header should be updated to use "Obj" for one or two of the other cases. "o" does not fit LLVM's current coding standards, and also does not match the name used in the .cpp file (see ELFDump.cpp).
If anything, the header should be updated to use "Obj" for one or two of the other cases. "o" does not fit LLVM's current coding standards, and also does not match the name used in the .cpp file (see ELFDump.cpp).
Shall I help update the arguments names in header file?
I don't really mind either way. Don't make wholesale changes to coding styles to update it to LLVM's style though. If you want to change anything, I'd just change printELFFileHeader, but I don't think it's really worth it unless you are changing the area of code already.