This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Using consistent arguments name
AbandonedPublic

Authored by Higuoxing on Nov 14 2018, 3:53 AM.

Details

Reviewers
jhenderson
Summary

I have confidence in this change, can I commit this directly?

Diff Detail

Event Timeline

Higuoxing created this revision.Nov 14 2018, 3:53 AM
Higuoxing edited the summary of this revision. (Show Details)
Higuoxing added a reviewer: jhenderson.
jhenderson requested changes to this revision.Nov 14 2018, 4:45 AM

If anything, the header should be updated to use "Obj" for one or two of the other cases. "o" does not fit LLVM's current coding standards, and also does not match the name used in the .cpp file (see ELFDump.cpp).

This revision now requires changes to proceed.Nov 14 2018, 4:45 AM
Higuoxing added a comment.EditedNov 14 2018, 4:53 AM

If anything, the header should be updated to use "Obj" for one or two of the other cases. "o" does not fit LLVM's current coding standards, and also does not match the name used in the .cpp file (see ELFDump.cpp).

Shall I help update the arguments names in header file?

I don't really mind either way. Don't make wholesale changes to coding styles to update it to LLVM's style though. If you want to change anything, I'd just change printELFFileHeader, but I don't think it's really worth it unless you are changing the area of code already.

Higuoxing abandoned this revision.Nov 14 2018, 5:49 AM