Page MenuHomePhabricator

Add ASan history threads into process_sp->GetExtendedThreadList, so they don't get freed too early
ClosedPublic

Authored by kubamracek on Sep 22 2014, 3:35 PM.

Details

Reviewers
kubamracek
Summary
  1. added the "process_sp->GetExtendedThreadList().AddThread (new_thread_sp);"

line when the ThreadSP is created, and also added this into the test case

  1. refactored the duplicate code into a CreateHistoryThreadFromValueObject function that is called twice.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 13960.Sep 22 2014, 3:35 PM
kubamracek retitled this revision from to Add ASan history threads into process_sp->GetExtendedThreadList, so they don't get freed too early.
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added a subscriber: Unknown Object (MLST).

Looks good, a couple changes to match the lldb coding style better; please commit.

source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp
119

Please split into two lines,

if (count <= 0)
  return;
124

open brace ('{') on the next line,

for (int i = 0; i < count; i++)
{
126

Pls plist condition expr & command so they're on separate lines.

kubamracek accepted this revision.Sep 23 2014, 11:30 AM
kubamracek added a reviewer: kubamracek.
This revision is now accepted and ready to land.Sep 23 2014, 11:30 AM
kubamracek closed this revision.Sep 23 2014, 11:30 AM

Thanks. Landed in r218323.