This is an archive of the discontinued LLVM Phabricator instance.

Extract construction of DataBufferLLVM into FileSystem
ClosedPublic

Authored by JDevlieghere on Nov 8 2018, 1:27 PM.

Details

Summary

This moves construction of data buffers into the FileSystem class. Like some of the previous refactorings we don't translate the path yet because the functionality hasn't been landed in LLVM yet.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Nov 8 2018, 1:27 PM
labath accepted this revision.Nov 10 2018, 1:50 AM

Looks fine to me, I'd just ask you to consider shortening the method names a bit.

include/lldb/Host/FileSystem.h
119–122 ↗(On Diff #173216)

Can we streamline these names? I don't think the FromPath part brings anything here when the method is on the filesystem class, as it's completely natural and expected for those methods to take paths. Maybe just CreateDataBuffer or ToDataBuffer

This revision is now accepted and ready to land.Nov 10 2018, 1:50 AM
This revision was automatically updated to reflect the committed changes.