Index: llvm/trunk/test/tools/dsymutil/X86/lc_build_version.test =================================================================== --- llvm/trunk/test/tools/dsymutil/X86/lc_build_version.test +++ llvm/trunk/test/tools/dsymutil/X86/lc_build_version.test @@ -0,0 +1,11 @@ +# RUN: dsymutil -f %p/../Inputs/lc_build_version.x86_64 -o - \ +# RUN: | obj2yaml | FileCheck %s + +CHECK: LoadCommands: +CHECK: - cmd: LC_BUILD_VERSION +CHECK-NEXT: cmdsize: 24 +CHECK-NEXT: platform: 1 +CHECK-NEXT: minos: 658944 +CHECK-NEXT: sdk: 658944 +CHECK-NEXT: ntools: 0 +CHECK-NEXT: - cmd Index: llvm/trunk/tools/dsymutil/MachOUtils.cpp =================================================================== --- llvm/trunk/tools/dsymutil/MachOUtils.cpp +++ llvm/trunk/tools/dsymutil/MachOUtils.cpp @@ -368,27 +368,34 @@ bool Is64Bit = Writer.is64Bit(); MachO::symtab_command SymtabCmd = InputBinary.getSymtabLoadCommand(); - // Get UUID. + // Compute the number of load commands we will need. + unsigned LoadCommandSize = 0; + unsigned NumLoadCommands = 0; + + // Get LC_UUID and LC_BUILD_VERSION. MachO::uuid_command UUIDCmd; + MachO::build_version_command BuildVersionCmd; memset(&UUIDCmd, 0, sizeof(UUIDCmd)); - UUIDCmd.cmd = MachO::LC_UUID; - UUIDCmd.cmdsize = sizeof(MachO::uuid_command); + memset(&BuildVersionCmd, 0, sizeof(BuildVersionCmd)); for (auto &LCI : InputBinary.load_commands()) { - if (LCI.C.cmd == MachO::LC_UUID) { + switch (LCI.C.cmd) { + case MachO::LC_UUID: UUIDCmd = InputBinary.getUuidCommand(LCI); + ++NumLoadCommands; + LoadCommandSize += sizeof(MachO::uuid_command); + break; + case MachO::LC_BUILD_VERSION: + BuildVersionCmd = InputBinary.getBuildVersionLoadCommand(LCI); + ++NumLoadCommands; + LoadCommandSize += sizeof(MachO::build_version_command); + // LLDB doesn't care about the build tools for now. + BuildVersionCmd.ntools = 0; + break; + default: break; } } - // Compute the number of load commands we will need. - unsigned LoadCommandSize = 0; - unsigned NumLoadCommands = 0; - // We will copy the UUID if there is one. - if (UUIDCmd.cmd != 0) { - ++NumLoadCommands; - LoadCommandSize += sizeof(MachO::uuid_command); - } - // If we have a valid symtab to copy, do it. bool ShouldEmitSymtab = isExecutable(InputBinary) && hasLinkEditSegment(InputBinary); @@ -452,10 +459,18 @@ assert(OutFile.tell() == HeaderSize); if (UUIDCmd.cmd != 0) { Writer.W.write(UUIDCmd.cmd); - Writer.W.write(UUIDCmd.cmdsize); + Writer.W.write(sizeof(UUIDCmd)); OutFile.write(reinterpret_cast(UUIDCmd.uuid), 16); assert(OutFile.tell() == HeaderSize + sizeof(UUIDCmd)); } + if (BuildVersionCmd.cmd != 0) { + Writer.W.write(BuildVersionCmd.cmd); + Writer.W.write(sizeof(BuildVersionCmd)); + Writer.W.write(BuildVersionCmd.platform); + Writer.W.write(BuildVersionCmd.minos); + Writer.W.write(BuildVersionCmd.sdk); + Writer.W.write(BuildVersionCmd.ntools); + } assert(SymtabCmd.cmd && "No symbol table."); uint64_t StringStart = SymtabStart + NumSyms * NListSize;