Index: test/TableGen/ConstraintChecking.inc =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking.inc @@ -0,0 +1,33 @@ +include "llvm/Target/Target.td" + +def TestTarget : Target; + +class Encoding : Instruction { + field bits<8> Inst; +} + +class TestReg enc> : Register { + let HWEncoding{15-1} = 0; + let HWEncoding{0} = enc; +} + +def R0 : TestReg<"R0", 0>; +def R1 : TestReg<"R1", 1>; +def Reg : RegisterClass<"TestTarget", [i32], 32, (sequence "R%d", 0, 1)>; + +class TestInstructionWithConstraints : Encoding { + dag OutOperandList = (outs Reg:$dest1, Reg:$dest2); + dag InOperandList = (ins Reg:$src1, Reg:$src2); + string AsmString = "mnemonic $dest1, $dest2, $src1, $src2"; + string AsmVariantName = ""; + let Constraints = cstr; + field bits<1> dest1; + field bits<1> dest2; + field bits<1> src1; + field bits<1> src2; + let Inst{7-4} = 0b1010; + let Inst{3} = dest1{0}; + let Inst{2} = dest2{0}; + let Inst{1} = src1{0}; + let Inst{0} = src2{0}; +} Index: test/TableGen/ConstraintChecking1.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking1.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Unrecognized constraint '$dest1 ~ $src2' in 'Foo' +def Foo : TestInstructionWithConstraints<"$dest1 ~ $src2">; Index: test/TableGen/ConstraintChecking2.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking2.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Illegal format for @earlyclobber constraint in 'Foo' +def Foo : TestInstructionWithConstraints<"@earlyclobber ">; Index: test/TableGen/ConstraintChecking3.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking3.td @@ -0,0 +1,8 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// (This is illegal because the '=' has to be surrounded by whitespace) + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Illegal format for tied-to constraint in 'Foo' +def Foo : TestInstructionWithConstraints<"$dest1=$dest2">; Index: test/TableGen/ConstraintChecking4.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking4.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Output operands '$dest1' and '$dest2' of 'Foo' cannot be tied! +def Foo : TestInstructionWithConstraints<"$dest1 = $dest2">; Index: test/TableGen/ConstraintChecking5.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking5.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Input operands '$src1' and '$src2' of 'Foo' cannot be tied! +def Foo : TestInstructionWithConstraints<"$src1 = $src2">; Index: test/TableGen/ConstraintChecking6.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking6.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Operand '$dest1' of 'Foo' cannot have multiple operands tied to it! +def Foo : TestInstructionWithConstraints<"$dest1 = $src1, $dest1 = $src2">; Index: test/TableGen/ConstraintChecking7.td =================================================================== --- /dev/null +++ test/TableGen/ConstraintChecking7.td @@ -0,0 +1,6 @@ +// RUN: not llvm-tblgen -gen-asm-writer -I %p -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s + +include "ConstraintChecking.inc" + +// CHECK: [[FILE]]:[[@LINE+1]]:1: error: Operand '$src1' of 'Foo' cannot have multiple constraints! +def Foo : TestInstructionWithConstraints<"$dest1 = $src1, $dest2 = $src1">; Index: utils/TableGen/CodeGenInstruction.h =================================================================== --- utils/TableGen/CodeGenInstruction.h +++ utils/TableGen/CodeGenInstruction.h @@ -57,6 +57,15 @@ assert(isTied()); return OtherTiedOperand; } + + bool operator==(const ConstraintInfo &RHS) const { + if (Kind != RHS.Kind) + return false; + if (Kind == Tied && OtherTiedOperand != RHS.OtherTiedOperand) + return false; + return true; + } + bool operator!=(const ConstraintInfo &RHS) const { return *this != RHS; } }; /// OperandInfo - The information we keep track of for each operand in the Index: utils/TableGen/CodeGenInstruction.cpp =================================================================== --- utils/TableGen/CodeGenInstruction.cpp +++ utils/TableGen/CodeGenInstruction.cpp @@ -202,7 +202,8 @@ return std::make_pair(0U, 0U); } -static void ParseConstraint(const std::string &CStr, CGIOperandList &Ops) { +static void ParseConstraint(const std::string &CStr, CGIOperandList &Ops, + Record *Rec) { // EARLY_CLOBBER: @early $reg std::string::size_type wpos = CStr.find_first_of(" \t"); std::string::size_type start = CStr.find_first_not_of(" \t"); @@ -211,13 +212,17 @@ std::string Name = CStr.substr(wpos+1); wpos = Name.find_first_not_of(" \t"); if (wpos == std::string::npos) - PrintFatalError("Illegal format for @earlyclobber constraint: '" + CStr + "'"); + PrintFatalError( + Rec->getLoc(), "Illegal format for @earlyclobber constraint in '" + + Rec->getName() + "': '" + CStr + "'"); Name = Name.substr(wpos); std::pair Op = Ops.ParseOperandName(Name, false); // Build the string for the operand if (!Ops[Op.first].Constraints[Op.second].isNone()) - PrintFatalError("Operand '" + Name + "' cannot have multiple constraints!"); + PrintFatalError( + Rec->getLoc(), "Operand '" + Name + "' of '" + Rec->getName() + + "' cannot have multiple constraints!"); Ops[Op.first].Constraints[Op.second] = CGIOperandList::ConstraintInfo::getEarlyClobber(); return; @@ -225,39 +230,75 @@ // Only other constraint is "TIED_TO" for now. std::string::size_type pos = CStr.find_first_of('='); - assert(pos != std::string::npos && "Unrecognized constraint"); + if (pos == std::string::npos) + PrintFatalError( + Rec->getLoc(), "Unrecognized constraint '" + CStr + + "' in '" + Rec->getName() + "'"); start = CStr.find_first_not_of(" \t"); std::string Name = CStr.substr(start, pos - start); // TIED_TO: $src1 = $dst wpos = Name.find_first_of(" \t"); if (wpos == std::string::npos) - PrintFatalError("Illegal format for tied-to constraint: '" + CStr + "'"); - std::string DestOpName = Name.substr(0, wpos); - std::pair DestOp = Ops.ParseOperandName(DestOpName, false); + PrintFatalError( + Rec->getLoc(), "Illegal format for tied-to constraint in '" + + Rec->getName() + "': '" + CStr + "'"); + std::string LHSOpName = Name.substr(0, wpos); + std::pair LHSOp = Ops.ParseOperandName(LHSOpName, false); Name = CStr.substr(pos+1); wpos = Name.find_first_not_of(" \t"); if (wpos == std::string::npos) - PrintFatalError("Illegal format for tied-to constraint: '" + CStr + "'"); + PrintFatalError( + Rec->getLoc(), "Illegal format for tied-to constraint: '" + CStr + "'"); + + std::string RHSOpName = Name.substr(wpos); + std::pair RHSOp = Ops.ParseOperandName(RHSOpName, false); + + // Sort the operands into order, which should put the output one + // first. But keep the original order, for use in diagnostics. + bool FirstIsDest = (LHSOp < RHSOp); + std::pair &DestOp = (FirstIsDest ? LHSOp : RHSOp); + std::string &DestOpName = (FirstIsDest ? LHSOpName : RHSOpName); + std::pair &SrcOp = (FirstIsDest ? RHSOp : LHSOp); + std::string &SrcOpName = (FirstIsDest ? RHSOpName : LHSOpName); + + // Ensure one operand is a def and the other is a use. + if (DestOp.first >= Ops.NumDefs) + PrintFatalError( + Rec->getLoc(), "Input operands '" + LHSOpName + "' and '" + RHSOpName + + "' of '" + Rec->getName() + "' cannot be tied!"); + if (SrcOp.first < Ops.NumDefs) + PrintFatalError( + Rec->getLoc(), "Output operands '" + LHSOpName + "' and '" + RHSOpName + + "' of '" + Rec->getName() + "' cannot be tied!"); + + // The constraint has to go on the operand with higher index, i.e. + // the source one. Check there isn't another constraint there + // already. + if (!Ops[SrcOp.first].Constraints[SrcOp.second].isNone()) + PrintFatalError( + Rec->getLoc(), "Operand '" + SrcOpName + "' of '" + Rec->getName() + + "' cannot have multiple constraints!"); - std::string SrcOpName = Name.substr(wpos); - std::pair SrcOp = Ops.ParseOperandName(SrcOpName, false); - if (SrcOp > DestOp) { - std::swap(SrcOp, DestOp); - std::swap(SrcOpName, DestOpName); + unsigned DestFlatOpNo = Ops.getFlattenedOperandNumber(DestOp); + auto NewConstraint = CGIOperandList::ConstraintInfo::getTied(DestFlatOpNo); + + // Check that the earlier operand is not the target of another tie + // before making it the target of this one. + for (auto Op : Ops) { + for (unsigned i = 0; i < Op.MINumOperands; i++) + if (Op.Constraints[i] == NewConstraint) + PrintFatalError( + Rec->getLoc(), "Operand '" + DestOpName + "' of '" + Rec->getName() + + "' cannot have multiple operands tied to it!"); } - unsigned FlatOpNo = Ops.getFlattenedOperandNumber(SrcOp); - - if (!Ops[DestOp.first].Constraints[DestOp.second].isNone()) - PrintFatalError("Operand '" + DestOpName + - "' cannot have multiple constraints!"); - Ops[DestOp.first].Constraints[DestOp.second] = - CGIOperandList::ConstraintInfo::getTied(FlatOpNo); + Ops[SrcOp.first].Constraints[SrcOp.second] = NewConstraint; } -static void ParseConstraints(const std::string &CStr, CGIOperandList &Ops) { +static void ParseConstraints(const std::string &CStr, CGIOperandList &Ops, + Record *Rec) { if (CStr.empty()) return; const std::string delims(","); @@ -269,7 +310,7 @@ if (eidx == std::string::npos) eidx = CStr.length(); - ParseConstraint(CStr.substr(bidx, eidx - bidx), Ops); + ParseConstraint(CStr.substr(bidx, eidx - bidx), Ops, Rec); bidx = CStr.find_first_not_of(delims, eidx); } } @@ -353,7 +394,7 @@ hasChain_Inferred = false; // Parse Constraints. - ParseConstraints(R->getValueAsString("Constraints"), Operands); + ParseConstraints(R->getValueAsString("Constraints"), Operands, R); // Parse the DisableEncoding field. Operands.ProcessDisableEncoding(R->getValueAsString("DisableEncoding"));