This is an archive of the discontinued LLVM Phabricator instance.

Differential D53709

Get rid of C-style cast.
ClosedPublic

Authored by aprantl on Oct 25 2018, 9:03 AM.

Details

Reviewers
shafik
Commits
rG6d0b9047a718: Get rid of casts. (NFC)
rLLDB345278: Get rid of casts. (NFC)
rL345278: Get rid of casts. (NFC)
Summary

This addresses review feedback from D53677.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Oct 25 2018, 9:03 AM
shafik added a comment.Oct 25 2018, 9:11 AM

LGTM

shafik accepted this revision.Oct 25 2018, 9:11 AM
This revision is now accepted and ready to land.Oct 25 2018, 9:11 AM
Closed by commit rL345278: Get rid of casts. (NFC) (authored by adrian). · Explain WhyOct 25 2018, 9:17 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 25 2018, 9:17 AM

Revision Contents

PathSize
lldb/
trunk/
source/
Plugins/
Platform/
MacOSX/
2 lines
4 lines

Diff 171119

lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.h

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Linespublic:
lldb_private::FileSpec LocateExecutable(const char *basename) override; lldb_private::FileSpec LocateExecutable(const char *basename) override;
lldb_private::Status lldb_private::Status
LaunchProcess(lldb_private::ProcessLaunchInfo &launch_info) override; LaunchProcess(lldb_private::ProcessLaunchInfo &launch_info) override;
static std::tuple<llvm::VersionTuple, llvm::StringRef> static std::tuple<llvm::VersionTuple, llvm::StringRef>
ParseVersionBuildDir(llvm::StringRef str); ParseVersionBuildDir(llvm::StringRef str);
enum class SDKType { enum SDKType : unsigned {
MacOSX = 0, MacOSX = 0,
iPhoneSimulator, iPhoneSimulator,
iPhoneOS, iPhoneOS,
}; };
protected: protected:
void ReadLibdispatchOffsetsAddress(lldb_private::Process *process); void ReadLibdispatchOffsetsAddress(lldb_private::Process *process);
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines

lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

Show First 20 Lines • Show All 1,396 Lines • ▼ Show 20 Lines
bool PlatformDarwin::SDKSupportsModules(SDKType desired_type, bool PlatformDarwin::SDKSupportsModules(SDKType desired_type,
const FileSpec &sdk_path) { const FileSpec &sdk_path) {
ConstString last_path_component = sdk_path.GetLastPathComponent(); ConstString last_path_component = sdk_path.GetLastPathComponent();
if (last_path_component) { if (last_path_component) {
const llvm::StringRef sdk_name = last_path_component.GetStringRef(); const llvm::StringRef sdk_name = last_path_component.GetStringRef();
if (!sdk_name.startswith(sdk_strings[(int)desired_type])) if (!sdk_name.startswith(sdk_strings[desired_type]))
return false; return false;
auto version_part = auto version_part =
sdk_name.drop_front(strlen(sdk_strings[(int)desired_type])); sdk_name.drop_front(strlen(sdk_strings[desired_type]));
version_part.consume_back(".sdk"); version_part.consume_back(".sdk");
llvm::VersionTuple version; llvm::VersionTuple version;
if (version.tryParse(version_part)) if (version.tryParse(version_part))
return false; return false;
return SDKSupportsModules(desired_type, version); return SDKSupportsModules(desired_type, version);
} }
▲ Show 20 Lines • Show All 359 Lines • Show Last 20 Lines