Page MenuHomePhabricator

[x32] Fix function indirect calls
ClosedPublic

Authored by pavel.v.chupin on Sep 15 2014, 8:28 AM.

Details

Summary

Zero-extend register to 64-bit for callq/jmpq.

Diff Detail

Repository
rL LLVM

Event Timeline

pavel.v.chupin retitled this revision from to [x32] Fix function indirect calls.
pavel.v.chupin updated this object.
pavel.v.chupin edited the test plan for this revision. (Show Details)
pavel.v.chupin added reviewers: nadav, dschuff.
pavel.v.chupin added subscribers: zinovy.nis, Unknown Object (MLST).
nadav edited edge metadata.Sep 15 2014, 9:14 AM

LGTM. :)

dschuff accepted this revision.Sep 15 2014, 9:30 AM
dschuff edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2014, 9:30 AM
pavel.v.chupin edited edge metadata.

Sorry, but this patch should be better than previous version. Modified 1 more test to catch ineffectiveness I didn't noticed before.
We need zero-extend only if callee address is in register.
Please review.

thanks, still LGTM

Diffusion closed this revision.Sep 17 2014, 12:19 AM
Diffusion updated this revision to Diff 13770.

Closed by commit rL217942 (authored by pvchupin).