Register TimeChecker with Clang Static Analyzer

[appcs]

Summary

Create a checker for "Year 2038" (Y2K38) related issues and register it with the Clang Static Analyzer.

[Szelethus]

Please reupload with full context (-U99999).

[Szelethus]

I very much like the idea!

Can you maybe add a couple testcases with todos about when your checker will emit a warning, and what the expected warning message will be?

And an entry to www/analyzer/alpha_checks.html would be great too :)

[appcs]

Re-spun with feedback received into: D53185

include/clang/StaticAnalyzer/Checkers/Checkers.td

   HelpText<"Check for calls to blocking functions inside a critical section">,
   DescFile<"BlockInCriticalSectionChecker.cpp">;
 
+def TimeChecker : Checker<"Time">,
+  HelpText<"Check time.h related functionality">,
+  DescFile<"TimeChecker.cpp">;
+
 } // end "alpha.unix"
 
 let ParentPackage = CString in {

lib/StaticAnalyzer/Checkers/CMakeLists.txt

   StreamChecker.cpp
   TaintTesterChecker.cpp
   TestAfterDivZeroChecker.cpp
+  TimeChecker.cpp
   TraversalChecker.cpp
   TrustNonnullChecker.cpp
   UndefBranchChecker.cpp

lib/StaticAnalyzer/Checkers/TimeChecker.cpp

+//===-- TimeChecker.cpp -------------------------------------------*- C++ -*--//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// Defines a checker for proper definition/use of time.h related functionality.
+//
+//===----------------------------------------------------------------------===//
+
+#include "ClangSACheckers.h"
+#include "clang/AST/RecursiveASTVisitor.h"
+#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
+#include "clang/StaticAnalyzer/Core/Checker.h"
+#include "clang/StaticAnalyzer/Core/CheckerManager.h"
+#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
+
+using namespace clang;
+using namespace ento;
+
+namespace {
+class TimeVisitor : public RecursiveASTVisitor<TimeVisitor> {
+  BugReporter &BR;
+  const CheckerBase *Checker;
+  AnalysisDeclContext *AC;
+
+public:
+  explicit TimeVisitor(BugReporter &B, const CheckerBase *Checker,
+                       AnalysisDeclContext *A)
+      : BR(B), Checker(Checker), AC(A) {}
+  bool VisitCastExpr(const CastExpr *CE);
+};
+} // namespace
+
+bool TimeVisitor::VisitCastExpr(const CastExpr *CE) {
+
+  // Implement check for casts on time_t values to types
+  // that are of shorter width or are unsigned, etc.
+
+  return true;
+}
+
+namespace {
+class TimeChecker : public Checker<check::ASTCodeBody> {
+public:
+  void checkASTCodeBody(const Decl *D, AnalysisManager &Mgr,
+                        BugReporter &BR) const {
+    TimeVisitor Visitor(BR, this, Mgr.getAnalysisDeclContext(D));
+    Visitor.TraverseDecl(const_cast<Decl *>(D));
+  }
+};
+} // end anonymous namespace
+
+void ento::registerTimeChecker(CheckerManager &mgr) {
+  mgr.registerChecker<TimeChecker>();
+}

test/Analysis/TimeCheckerRegistration.cpp

+// RUN: %clang_cc1 -analyzer-checker-help | FileCheck %s
+
+CHECK: alpha.unix.Time Check time.h related functionality