Index: lib/Target/ARM/ARMComputeBlockSize.cpp =================================================================== --- lib/Target/ARM/ARMComputeBlockSize.cpp +++ lib/Target/ARM/ARMComputeBlockSize.cpp @@ -51,14 +51,21 @@ BBI.PostAlign = 0; for (MachineInstr &I : *MBB) { - BBI.Size += TII->getInstSizeInBytes(I); + unsigned InstSize = TII->getInstSizeInBytes(I); // For inline asm, getInstSizeInBytes returns a conservative estimate. // The actual size may be smaller, but still a multiple of the instr size. - if (I.isInlineAsm()) + if (I.isInlineAsm()) { BBI.Unalign = isThumb ? 1 : 2; + // Account for worst case of an extra implicit IT instruction + // for each 4-byte Thumb instruction. + if (isThumb) + InstSize += InstSize / 2; + } // Also consider instructions that may be shrunk later. else if (isThumb && mayOptimizeThumb2Instruction(&I)) BBI.Unalign = 1; + + BBI.Size += InstSize; } // tBR_JTr contains a .align 2 directive. Index: test/CodeGen/ARM/cbz-implicit-it-range.ll =================================================================== --- /dev/null +++ test/CodeGen/ARM/cbz-implicit-it-range.ll @@ -0,0 +1,47 @@ +;RUN: llc -O2 -mtriple=thumbv7a-linux-gnueabihf -arm-implicit-it=always %s -o - | FileCheck %s +;RUN llc -O2 -mtriple=thumbv7a-linux-gnueabihf -no-integrated-as %s -o - + +; Check that we do not produce a CBZ instruction to jump over the inline +; assembly as the distance is too far if the implicit IT instructions are +; added. + +define void @f0(i32 %p1, i32 %p2, i32 %p3) nounwind { +entry: + %cmp = icmp eq i32 %p1, 0 + br i1 %cmp, label %if.else, label %if.then + +if.then: + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + tail call void asm sideeffect "movseq r0, #0\0A", ""() + br label %if.end + +if.else: + tail call void asm sideeffect "nop\0A", ""() + br label %if.end + +if.end: + ret void +} +; CHECK-LABEL: f0: +; CHECK: beq .LBB0_{{[0-9]+}} +