Index: clang-tools-extra/trunk/clang-tidy/bugprone/UseAfterMoveCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/bugprone/UseAfterMoveCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/bugprone/UseAfterMoveCheck.cpp @@ -102,8 +102,9 @@ if (!TheCFG) return false; - Sequence.reset(new ExprSequence(TheCFG.get(), Context)); - BlockMap.reset(new StmtToBlockMap(TheCFG.get(), Context)); + Sequence = + llvm::make_unique(TheCFG.get(), FunctionBody, Context); + BlockMap = llvm::make_unique(TheCFG.get(), Context); Visited.clear(); const CFGBlock *Block = BlockMap->blockContainingStmt(MovingCall); Index: clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.h =================================================================== --- clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.h +++ clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.h @@ -69,8 +69,8 @@ class ExprSequence { public: /// Initializes this `ExprSequence` with sequence information for the given - /// `CFG`. - ExprSequence(const CFG *TheCFG, ASTContext *TheContext); + /// `CFG`. `Root` is the root statement the CFG was built from. + ExprSequence(const CFG *TheCFG, const Stmt *Root, ASTContext *TheContext); /// Returns whether \p Before is sequenced before \p After. bool inSequence(const Stmt *Before, const Stmt *After) const; @@ -94,6 +94,7 @@ const Stmt *resolveSyntheticStmt(const Stmt *S) const; ASTContext *Context; + const Stmt *Root; llvm::DenseMap SyntheticStmtSourceMap; }; Index: clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.cpp +++ clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.cpp @@ -63,8 +63,9 @@ } } -ExprSequence::ExprSequence(const CFG *TheCFG, ASTContext *TheContext) - : Context(TheContext) { +ExprSequence::ExprSequence(const CFG *TheCFG, const Stmt *Root, + ASTContext *TheContext) + : Context(TheContext), Root(Root) { for (const auto &SyntheticStmt : TheCFG->synthetic_stmts()) { SyntheticStmtSourceMap[SyntheticStmt.first] = SyntheticStmt.second; } @@ -99,6 +100,11 @@ const Stmt *ExprSequence::getSequenceSuccessor(const Stmt *S) const { for (const Stmt *Parent : getParentStmts(S, Context)) { + // If a statement has multiple parents, make sure we're using the parent + // that lies within the sub-tree under Root. + if (!isDescendantOrEqual(Parent, Root, Context)) + continue; + if (const auto *BO = dyn_cast(Parent)) { // Comma operator: Right-hand side is sequenced after the left-hand side. if (BO->getLHS() == S && BO->getOpcode() == BO_Comma) Index: clang-tools-extra/trunk/test/clang-tidy/bugprone-use-after-move.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/bugprone-use-after-move.cpp +++ clang-tools-extra/trunk/test/clang-tidy/bugprone-use-after-move.cpp @@ -1195,6 +1195,18 @@ } } +// Some statements in templates (e.g. null, break and continue statements) may +// be shared between the uninstantiated and instantiated versions of the +// template and therefore have multiple parents. Make sure the sequencing code +// handles this correctly. +template void nullStatementSequencesInTemplate() { + int c = 0; + (void)c; + ; + std::move(c); +} +template void nullStatementSequencesInTemplate(); + namespace PR33020 { class D { ~D();