Index: test/clang-tidy/fuchsia-default-arguments.cpp =================================================================== --- test/clang-tidy/fuchsia-default-arguments.cpp +++ test/clang-tidy/fuchsia-default-arguments.cpp @@ -1,14 +1,14 @@ // RUN: %check_clang_tidy %s fuchsia-default-arguments %t int foo(int value = 5) { return value; } -// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes // CHECK-FIXES: int foo(int value) { return value; } int f() { foo(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: - // CHECK-NEXT: int foo(int value = 5) { return value; } + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-8]]:9: note: default parameter was declared here } int bar(int value) { return value; } @@ -21,7 +21,8 @@ class Baz { public: int a(int value = 5) { return value; } - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes // CHECK-FIXES: int a(int value) { return value; } int b(int value) { return value; } @@ -30,7 +31,8 @@ class Foo { // Fix should be suggested in declaration int a(int value = 53); - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes // CHECK-FIXES: int a(int value); }; @@ -41,7 +43,8 @@ // Elided functions void f(int = 5) {}; -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-2]]:11: note: FIX-IT applied suggested code changes // CHECK-FIXES: void f(int) {}; void g(int) {}; @@ -50,12 +53,13 @@ #define D(val) = val void h(int i D(5)); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES-NOT: void h(int i); void x(int i); void x(int i = 12); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-2]]:13: note: FIX-IT applied suggested code changes // CHECK-FIXES: void x(int i); void x(int i) {} @@ -65,17 +69,18 @@ }; void S::x(int i = 12) {} -// CHECK-MESSAGES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-2]]:16: note: FIX-IT applied suggested code changes // CHECK-FIXES: void S::x(int i) {} int main() { S s; s.x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-9]]:11: note: default parameter was declared here // CHECK-NEXT: void S::x(int i = 12) {} x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-19]]:8: note: default parameter was declared here // CHECK-NEXT: void x(int i = 12); }