This is an archive of the discontinued LLVM Phabricator instance.

Drop the W postfix on the 16-bit registers.
ClosedPublic

Authored by jobnoorman on Sep 9 2014, 6:56 AM.

Details

Reviewers
asl
Summary

This ensures the inline assembly register constraints are properly recognised in TargetLowering::getRegForInlineAsmConstraint.

Diff Detail

Event Timeline

jobnoorman updated this revision to Diff 13459.Sep 9 2014, 6:56 AM
jobnoorman retitled this revision from to Drop the W postfix on the 16-bit registers..
jobnoorman updated this object.
jobnoorman edited the test plan for this revision. (Show Details)
jobnoorman added a reviewer: asl.
asl accepted this revision.Sep 9 2014, 10:35 AM
asl edited edge metadata.

This looks pretty weird, that we match of node name, not the assembler name, but.... LGTM

This revision is now accepted and ready to land.Sep 9 2014, 10:35 AM
jobnoorman closed this revision.Sep 10 2014, 12:09 AM

Yes, that took me by surprise as well :-)

Thanks for the review! r217479.

asl added a comment.Sep 10 2014, 3:34 PM

Maybe we can extend the logic in target lowering and will match assembler name of a register as well? This looks extremely reasonable.

Yes, I think we should do this (maybe even drop matching on the node name completely?). Once I have some time, I'll try to prepare a patch and post it for review.