Index: lib/Analysis/ConstantFolding.cpp =================================================================== --- lib/Analysis/ConstantFolding.cpp +++ lib/Analysis/ConstantFolding.cpp @@ -1363,6 +1363,8 @@ case Intrinsic::fabs: case Intrinsic::minnum: case Intrinsic::maxnum: + case Intrinsic::minnan: + case Intrinsic::maxnan: case Intrinsic::log: case Intrinsic::log2: case Intrinsic::log10: @@ -1912,6 +1914,18 @@ return ConstantFP::get(Ty->getContext(), maxnum(C1, C2)); } + if (IntrinsicID == Intrinsic::minnan) { + const APFloat &C1 = Op1->getValueAPF(); + const APFloat &C2 = Op2->getValueAPF(); + return ConstantFP::get(Ty->getContext(), minnan(C1, C2)); + } + + if (IntrinsicID == Intrinsic::maxnan) { + const APFloat &C1 = Op1->getValueAPF(); + const APFloat &C2 = Op2->getValueAPF(); + return ConstantFP::get(Ty->getContext(), maxnan(C1, C2)); + } + if (!TLI) return nullptr; if ((Name == "pow" && TLI->has(LibFunc_pow)) || Index: test/Analysis/ConstantFolding/min-max.ll =================================================================== --- /dev/null +++ test/Analysis/ConstantFolding/min-max.ll @@ -0,0 +1,84 @@ +; RUN: opt -instcombine -S -o - %s | FileCheck %s +; Tests that constant folding of min and max operations works as expected. + +declare float @llvm.minnum.f32(float, float) +declare float @llvm.maxnum.f32(float, float) +declare <4 x float> @llvm.minnum.v4f32(<4 x float>, <4 x float>) +declare <4 x float> @llvm.maxnum.v4f32(<4 x float>, <4 x float>) + +declare float @llvm.minnan.f32(float, float) +declare float @llvm.maxnan.f32(float, float) +declare <4 x float> @llvm.minnan.v4f32(<4 x float>, <4 x float>) +declare <4 x float> @llvm.maxnan.v4f32(<4 x float>, <4 x float>) + +; CHECK: define float @minnum_float() { +define float @minnum_float() { + ; CHECK-NEXT: ret float 5.000000e+00 + %1 = call float @llvm.minnum.f32(float 5.0, float 42.0) + ret float %1 +} + +; CHECK: define <4 x float> @minnum_float_vec() { +define <4 x float> @minnum_float_vec() { + ; CHECK-NEXT: ret <4 x float> + %1 = call <4 x float> @llvm.minnum.v4f32( + <4 x float> , + <4 x float> + ) + ret <4 x float> %1 +} + +; CHECK: define float @maxnum_float() { +define float @maxnum_float() { + ; CHECK-NEXT: ret float 4.200000e+01 + %1 = call float @llvm.maxnum.f32(float 5.0, float 42.0) + ret float %1 +} + +; CHECK: define <4 x float> @maxnum_float_vec() { +define <4 x float> @maxnum_float_vec() { + ; CHECK-NEXT: ret <4 x float> + %1 = call <4 x float> @llvm.maxnum.v4f32( + <4 x float> , + <4 x float> + ) + ret <4 x float> %1 +} + +; CHECK: define float @minnan_float() { +define float @minnan_float() { + ; CHECK-NEXT: ret float 5.000000e+00 + %1 = call float @llvm.minnan.f32(float 5.0, float 42.0) + ret float %1 +} + +; CHECK: define <4 x float> @minnan_float_vec() { +define <4 x float> @minnan_float_vec() { + ; CHECK-NEXT: ret <4 x float> + %1 = call <4 x float> @llvm.minnan.v4f32( + <4 x float> , + <4 x float> + ) + ret <4 x float> %1 +} + +; CHECK: define float @maxnan_float() { +define float @maxnan_float() { + ; CHECK-NEXT: ret float 4.200000e+01 + %1 = call float @llvm.maxnan.f32(float 5.0, float 42.0) + ret float %1 +} + +; CHECK: define <4 x float> @maxnan_float_vec() { +define <4 x float> @maxnan_float_vec() { + ; CHECK-NEXT: ret <4 x float> + %1 = call <4 x float> @llvm.maxnan.v4f32( + <4 x float> , + <4 x float> + ) + ret <4 x float> %1 +} Index: unittests/ADT/APFloatTest.cpp =================================================================== --- unittests/ADT/APFloatTest.cpp +++ unittests/ADT/APFloatTest.cpp @@ -555,6 +555,28 @@ EXPECT_EQ(1.0, maxnum(nan, f1).convertToDouble()); } +TEST(APFloatTest, MinNan) { + APFloat f1(1.0); + APFloat f2(2.0); + APFloat nan = APFloat::getNaN(APFloat::IEEEdouble()); + + EXPECT_EQ(1.0, minnan(f1, f2).convertToDouble()); + EXPECT_EQ(1.0, minnan(f2, f1).convertToDouble()); + EXPECT_TRUE(std::isnan(minnan(f1, nan).convertToDouble())); + EXPECT_TRUE(std::isnan(minnan(nan, f1).convertToDouble())); +} + +TEST(APFloatTest, MaxNan) { + APFloat f1(1.0); + APFloat f2(2.0); + APFloat nan = APFloat::getNaN(APFloat::IEEEdouble()); + + EXPECT_EQ(2.0, maxnan(f1, f2).convertToDouble()); + EXPECT_EQ(2.0, maxnan(f2, f1).convertToDouble()); + EXPECT_TRUE(std::isnan(maxnan(f1, nan).convertToDouble())); + EXPECT_TRUE(std::isnan(maxnan(nan, f1).convertToDouble())); +} + TEST(APFloatTest, Denormal) { APFloat::roundingMode rdmd = APFloat::rmNearestTiesToEven;