Index: llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp =================================================================== --- llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp +++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp @@ -789,6 +789,10 @@ ORE->emit(createMissedAnalysis("NoInductionVariable") << "loop induction variable could not be identified"); return false; + } else if (!WidestIndTy) { + ORE->emit(createMissedAnalysis("NoIntegerInductionVariable") + << "integer loop induction variable could not be identified"); + return false; } } Index: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp =================================================================== --- llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp +++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -2303,6 +2303,7 @@ "Invalid loop count"); Type *IdxTy = Legal->getWidestInductionType(); + assert(IdxTy && "No type for induction"); // The exit count might have the type of i64 while the phi is i32. This can // happen if we have an induction variable that is sign extended before the Index: llvm/trunk/test/Transforms/LoopVectorize/pr37515.ll =================================================================== --- llvm/trunk/test/Transforms/LoopVectorize/pr37515.ll +++ llvm/trunk/test/Transforms/LoopVectorize/pr37515.ll @@ -0,0 +1,20 @@ +; RUN: opt -passes='loop-vectorize' -S -pass-remarks-missed=loop-vectorize < %s 2>&1 | FileCheck %s +; +; FP primary induction is not supported in LV. Make sure Legal bails out. +; +; CHECK: loop not vectorized + +define void @PR37515() { +entry: + br label %loop + +loop: + %p = phi float [ 19.0, %entry ], [ %a, %loop ] + %a = fadd fast float %p, -1.0 + %m = fmul fast float %a, %a + %c = fcmp fast ugt float %a, 2.0 + br i1 %c, label %loop, label %exit + +exit: + unreachable +} Index: llvm/trunk/test/Transforms/LoopVectorize/pr38800.ll =================================================================== --- llvm/trunk/test/Transforms/LoopVectorize/pr38800.ll +++ llvm/trunk/test/Transforms/LoopVectorize/pr38800.ll @@ -0,0 +1,34 @@ +; RUN: opt -loop-vectorize -force-vector-width=2 -pass-remarks-missed='loop-vectorize' -S < %s 2>&1 | FileCheck %s + +; CHECK: remark: :0:0: loop not vectorized: integer loop induction variable could not be identified + +; Test-case ('-O2 -ffast-math') from PR38800. +; (Set '-force-vector-width=2' to enable vector code generation.) +; +; No integral induction variable in the source-code caused a compiler-crash +; when attempting to vectorize. With the fix, a remark indicating why it +; wasn't vectorized is produced +; +;void foo(float *ptr, float val) { +; float f; +; for (f = 0.1f; f < 1.0f; f += 0.01f) +; *ptr += val; +;} + +define void @foo(float* nocapture %ptr, float %val) local_unnamed_addr { +entry: + %ptr.promoted = load float, float* %ptr, align 4 + br label %for.body + +for.body: ; preds = %entry, %for.body + %add5 = phi float [ %ptr.promoted, %entry ], [ %add, %for.body ] + %f.04 = phi float [ 0x3FB99999A0000000, %entry ], [ %add1, %for.body ] + %add = fadd fast float %add5, %val + %add1 = fadd fast float %f.04, 0x3F847AE140000000 + %cmp = fcmp fast olt float %add1, 1.000000e+00 + br i1 %cmp, label %for.body, label %for.end + +for.end: ; preds = %for.body + store float %add, float* %ptr, align 4 + ret void +}