[NFC] Fixed enum constant in boolean context error

[xbolva00]

Summary

/home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:656:59: warning: enum constant in boolean context [-Wint-in-bool-context]

if (mh.magic == llvm::MachO::MH_CIGAM || llvm::MachO::MH_MAGIC)
                                                      ^~~~~~~~

/home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:658:62: warning: enum constant in boolean context [-Wint-in-bool-context]

if (mh.magic == llvm::MachO::MH_CIGAM_64 || llvm::MachO::MH_MAGIC_64)

[teemperor]

This whole code doesn't seem to have test coverage, so I'll not demand a test for this. Also this patch is clearly fixing a typo, so let's get this in.

[clayborg]

If you insert the text:

Differential Revision: https://reviews.llvm.org/D51600

Into your commit it will automatically show the SVN revision that was used for the commit. Can you attach the SVN revision to this as a comment so we can track this?

[teemperor]

(you can also try arcanist which will do this automatically for you)

[xbolva00]

In D51600#1223303, @clayborg wrote:

If you insert the text:

Differential Revision: https://reviews.llvm.org/D51600

Into your commit it will automatically show the SVN revision that was used for the commit. Can you attach the SVN revision to this as a comment so we can track this?

In D51600#1223308, @teemperor wrote:

(you can also try arcanist which will do this automatically for you)

Ok, I will add it, thanks.

Btw, it is a bit strange, I used:
arc patch D51600
arc commit --revision D51600

Edit: Well, I see that lines in rL341340 and rLLDB341340 :)
Edit2: Ok, I see what you mean.

[xbolva00]

Ok, I probably messed up my LLDB svn a bit yesterday so yes, I have found the reason of that strange behavior :D Sorry, I will re-setup it locally. Thanks.

source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

bool DynamicLoaderDarwinKernel::KextImageInfo::ReadMemoryModule(
   if (m_load_address == LLDB_INVALID_ADDRESS)
     return false;
 
   FileSpec file_spec;
   file_spec.SetFile(m_name.c_str(), false, FileSpec::Style::native);
 
   llvm::MachO::mach_header mh;
   size_t size_to_read = 512;
-  if (ReadMachHeader (m_load_address, process, mh)) {
-    if (mh.magic == llvm::MachO::MH_CIGAM || llvm::MachO::MH_MAGIC)
-      size_to_read = sizeof (llvm::MachO::mach_header) + mh.sizeofcmds;
-    if (mh.magic == llvm::MachO::MH_CIGAM_64 || llvm::MachO::MH_MAGIC_64)
-      size_to_read = sizeof (llvm::MachO::mach_header_64) + mh.sizeofcmds;
+  if (ReadMachHeader(m_load_address, process, mh)) {
+    if (mh.magic == llvm::MachO::MH_CIGAM || mh.magic == llvm::MachO::MH_MAGIC)
+      size_to_read = sizeof(llvm::MachO::mach_header) + mh.sizeofcmds;
+    if (mh.magic == llvm::MachO::MH_CIGAM_64 ||
+        mh.magic == llvm::MachO::MH_MAGIC_64)
+      size_to_read = sizeof(llvm::MachO::mach_header_64) + mh.sizeofcmds;
   }
 
   ModuleSP memory_module_sp =
       process->ReadModuleFromMemory(file_spec, m_load_address, size_to_read);
 
   if (memory_module_sp.get() == NULL)
     return false;