This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add Itineraries of IIC_IntRotateDI for P7/P8
ClosedPublic

Authored by jsji on Aug 30 2018, 2:15 PM.

Details

Summary

When doing some instruction scheduling work, we noticed some missing itineraries.

Before we switch to machine scheduler, those missing itineraries might not have impact to actually scheduling,
because we can still get same latency due to default values.

With machine scheduler, however, itineraries will have impact to scheduling.
eg: NumMicroOps will default to be 0 if there is NO itineraries for specific instruction class.
And most of the instruction class with itineraries will have NumMicroOps default to 1.

This will has impact on the count of RetiredMOps, affects the Pending/Available Queue,
then causing different scheduling or suboptimal scheduling further.

This patch is for IIC_IntRotateDI first, as there are some existing testcases that can demonstrate the scheduling change.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Aug 30 2018, 2:15 PM
jsji updated this revision to Diff 163411.Aug 30 2018, 2:38 PM

Update diff to include more context.

nemanjai accepted this revision.Aug 31 2018, 4:43 AM

LGTM. Thanks on working on completing the set of itineraries.

This revision is now accepted and ready to land.Aug 31 2018, 4:43 AM
This revision was automatically updated to reflect the committed changes.