Index: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h =================================================================== --- clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h +++ clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h @@ -139,8 +139,8 @@ virtual SVal simplifySVal(ProgramStateRef State, SVal Val) = 0; /// Constructs a symbolic expression for two non-location values. - SVal makeSymExprValNN(ProgramStateRef state, BinaryOperator::Opcode op, - NonLoc lhs, NonLoc rhs, QualType resultTy); + SVal makeSymExprValNN(BinaryOperator::Opcode op, + NonLoc lhs, NonLoc rhs, QualType resultTy); SVal evalBinOp(ProgramStateRef state, BinaryOperator::Opcode op, SVal lhs, SVal rhs, QualType type); Index: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp =================================================================== --- clang/lib/StaticAnalyzer/Core/SValBuilder.cpp +++ clang/lib/StaticAnalyzer/Core/SValBuilder.cpp @@ -375,8 +375,7 @@ } } -SVal SValBuilder::makeSymExprValNN(ProgramStateRef State, - BinaryOperator::Opcode Op, +SVal SValBuilder::makeSymExprValNN(BinaryOperator::Opcode Op, NonLoc LHS, NonLoc RHS, QualType ResultTy) { const SymExpr *symLHS = LHS.getAsSymExpr(); Index: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp =================================================================== --- clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp +++ clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp @@ -534,7 +534,7 @@ while (1) { switch (lhs.getSubKind()) { default: - return makeSymExprValNN(state, op, lhs, rhs, resultTy); + return makeSymExprValNN(op, lhs, rhs, resultTy); case nonloc::PointerToMemberKind: { assert(rhs.getSubKind() == nonloc::PointerToMemberKind && "Both SVals should have pointer-to-member-type"); @@ -582,7 +582,7 @@ return makeTruthVal(true, resultTy); default: // This case also handles pointer arithmetic. - return makeSymExprValNN(state, op, InputLHS, InputRHS, resultTy); + return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); } } } @@ -643,9 +643,9 @@ // 0<>a if (LHSValue == 0) return evalCastFromNonLoc(lhs, resultTy); - return makeSymExprValNN(state, op, InputLHS, InputRHS, resultTy); + return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); default: - return makeSymExprValNN(state, op, InputLHS, InputRHS, resultTy); + return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); } } case nonloc::SymbolValKind: { @@ -757,7 +757,7 @@ return *V; // Give up -- this is not a symbolic expression we can handle. - return makeSymExprValNN(state, op, InputLHS, InputRHS, resultTy); + return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); } } }