Page MenuHomePhabricator

[X86] Refactor X86ISelDAGToDAG::SelectAtomicLoadArith - NFC
ClosedPublic

Authored by morisset on Aug 27 2014, 2:01 PM.

Details

Summary

Mostly renaming the (not very explicit) variables Tmp0, .. Tmp4, and grouping
related statements together, along with a few lines of comments for the
surprising parts.

No functional change intended.

Diff Detail

Repository
rL LLVM

Event Timeline

morisset updated this revision to Diff 13000.Aug 27 2014, 2:01 PM
morisset retitled this revision from to [X86] Refactor X86ISelDAGToDAG::SelectAtomicLoadArith - NFC.
morisset updated this object.
morisset edited the test plan for this revision. (Show Details)
morisset added a reviewer: jfb.
morisset added a subscriber: Unknown Object (MLST).
jfb edited edge metadata.Aug 27 2014, 2:06 PM

You commit message should state that this patch has no intended functional changes.

lib/Target/X86/X86ISelDAGToDAG.cpp
1825 ↗(On Diff #13000)

Drop this line.

1886 ↗(On Diff #13000)

Missing a space after Opc.

morisset updated this revision to Diff 13004.EditedAug 27 2014, 2:45 PM
morisset edited edge metadata.

Fix both lines based on comments by jfb.

I had put NFC in the title, but I agree I should have repeated it in the summary.

morisset updated this object.Aug 27 2014, 3:00 PM
jfb accepted this revision.Aug 27 2014, 3:01 PM
jfb edited edge metadata.

lgtm after description update. Please leave this open for a short while, to make sure there are no objections.

This revision is now accepted and ready to land.Aug 27 2014, 3:01 PM
morisset closed this revision.Aug 29 2014, 1:28 PM
morisset updated this revision to Diff 13102.

Closed by commit rL216768 (authored by @morisset).