Index: llvm/trunk/lib/Transforms/Scalar/ConstantProp.cpp =================================================================== --- llvm/trunk/lib/Transforms/Scalar/ConstantProp.cpp +++ llvm/trunk/lib/Transforms/Scalar/ConstantProp.cpp @@ -18,21 +18,25 @@ // //===----------------------------------------------------------------------===// +#include "llvm/ADT/SmallPtrSet.h" +#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/Statistic.h" #include "llvm/Analysis/ConstantFolding.h" #include "llvm/Analysis/TargetLibraryInfo.h" -#include "llvm/Transforms/Utils/Local.h" #include "llvm/IR/Constant.h" #include "llvm/IR/InstIterator.h" #include "llvm/IR/Instruction.h" #include "llvm/Pass.h" +#include "llvm/Support/DebugCounter.h" #include "llvm/Transforms/Scalar.h" -#include +#include "llvm/Transforms/Utils/Local.h" using namespace llvm; #define DEBUG_TYPE "constprop" STATISTIC(NumInstKilled, "Number of instructions killed"); +DEBUG_COUNTER(CPCounter, "constprop-transform", + "Controls which instructions are killed"); namespace { struct ConstantPropagation : public FunctionPass { @@ -66,9 +70,15 @@ return false; // Initialize the worklist to all of the instructions ready to process... - std::set WorkList; - for (Instruction &I: instructions(&F)) + SmallPtrSet WorkList; + // The SmallVector of WorkList ensures that we do iteration at stable order. + // We use two containers rather than one SetVector, since remove is + // linear-time, and we don't care enough to remove from Vec. + SmallVector WorkListVec; + for (Instruction &I : instructions(&F)) { WorkList.insert(&I); + WorkListVec.push_back(&I); + } bool Changed = false; const DataLayout &DL = F.getParent()->getDataLayout(); @@ -76,29 +86,36 @@ &getAnalysis().getTLI(); while (!WorkList.empty()) { - Instruction *I = *WorkList.begin(); - WorkList.erase(WorkList.begin()); // Get an element from the worklist... + SmallVector NewWorkListVec; + for (auto *I : WorkListVec) { + WorkList.erase(I); // Remove element from the worklist... + + if (!I->use_empty()) // Don't muck with dead instructions... + if (Constant *C = ConstantFoldInstruction(I, DL, TLI)) { + if (!DebugCounter::shouldExecute(CPCounter)) + continue; + + // Add all of the users of this instruction to the worklist, they might + // be constant propagatable now... + for (User *U : I->users()) { + // If user not in the set, then add it to the vector. + if (WorkList.insert(cast(U)).second) + NewWorkListVec.push_back(cast(U)); + } + + // Replace all of the uses of a variable with uses of the constant. + I->replaceAllUsesWith(C); + + if (isInstructionTriviallyDead(I, TLI)) { + I->eraseFromParent(); + ++NumInstKilled; + } - if (!I->use_empty()) // Don't muck with dead instructions... - if (Constant *C = ConstantFoldInstruction(I, DL, TLI)) { - // Add all of the users of this instruction to the worklist, they might - // be constant propagatable now... - for (User *U : I->users()) - WorkList.insert(cast(U)); - - // Replace all of the uses of a variable with uses of the constant. - I->replaceAllUsesWith(C); - - // Remove the dead instruction. - WorkList.erase(I); - if (isInstructionTriviallyDead(I, TLI)) { - I->eraseFromParent(); - ++NumInstKilled; + // We made a change to the function... + Changed = true; } - - // We made a change to the function... - Changed = true; - } + } + WorkListVec = std::move(NewWorkListVec); } return Changed; }