This is an archive of the discontinued LLVM Phabricator instance.

Add the actually calculated completions to COMPLETION_MSG
ClosedPublic

Authored by teemperor on Jul 27 2018, 4:23 PM.

Reviewers: None
Commits: rG7bb4de47c9fc: Add the actually calculated completions to COMPLETION_MSG
rLLDB338179: Add the actually calculated completions to COMPLETION_MSG
rL338179: Add the actually calculated completions to COMPLETION_MSG

Summary

Otherwise this assertion message is not very useful to whoever is reading the log.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2018, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

packages/

Python/

lldbsuite/

test/

functionalities/

completion/

4 lines

5 lines

Show First 20 Lines • Show All 307 Lines • ▼ Show 20 Lines	def complete_from_to(self, str_input, patterns, turn_off_re_match=False):
compare_string = ""		compare_string = ""
for idx in range(1, num_matches+1):		for idx in range(1, num_matches+1):
compare_string += match_strings.GetStringAtIndex(idx) + "\n"		compare_string += match_strings.GetStringAtIndex(idx) + "\n"

for p in patterns:		for p in patterns:
if turn_off_re_match:		if turn_off_re_match:
self.expect(		self.expect(
compare_string, msg=COMPLETION_MSG(		compare_string, msg=COMPLETION_MSG(
str_input, p), exe=False, substrs=[p])		str_input, p, match_strings), exe=False, substrs=[p])
else:		else:
self.expect(		self.expect(
compare_string, msg=COMPLETION_MSG(		compare_string, msg=COMPLETION_MSG(
str_input, p), exe=False, patterns=[p])		str_input, p, match_strings), exe=False, patterns=[p])

	Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
	WATCHPOINT_CREATED = "Watchpoint created successfully"			WATCHPOINT_CREATED = "Watchpoint created successfully"


	def CMD_MSG(str):			def CMD_MSG(str):
	'''A generic "Command '%s' returns successfully" message generator.'''			'''A generic "Command '%s' returns successfully" message generator.'''
	return "Command '%s' returns successfully" % str			return "Command '%s' returns successfully" % str


	def COMPLETION_MSG(str_before, str_after):			def COMPLETION_MSG(str_before, str_after, completions):
	'''A generic message generator for the completion mechanism.'''			'''A generic message generator for the completion mechanism.'''
	return "'%s' successfully completes to '%s'" % (str_before, str_after)			return ("'%s' successfully completes to '%s', but completions were:\n%s"
				% (str_before, str_after, "\n".join(completions)))


	def EXP_MSG(str, actual, exe):			def EXP_MSG(str, actual, exe):
	'''A generic "'%s' returns expected result" message generator if exe.			'''A generic "'%s' returns expected result" message generator if exe.
	Otherwise, it generates "'%s' matches expected result" message.'''			Otherwise, it generates "'%s' matches expected result" message.'''

	return "'%s' %s expected result, got '%s'" % (			return "'%s' %s expected result, got '%s'" % (
	str, 'returns' if exe else 'matches', actual.strip())			str, 'returns' if exe else 'matches', actual.strip())
	▲ Show 20 Lines • Show All 2,168 Lines • Show Last 20 Lines