This is an archive of the discontinued LLVM Phabricator instance.

[COFF] clean up global resources after completion
ClosedPublic

Authored by andrewrk on Jul 26 2018, 8:15 AM.

Details

Summary

Previously, running lld::coff::link() twice in the same process would access stale pointers because of these global variables not being reset. After this patch, lld::coff::link() can be called any number of times, just like its ELF and MACH-O counterparts.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

andrewrk created this revision.Jul 26 2018, 8:15 AM
ruiu accepted this revision.Jul 26 2018, 10:01 AM

LGTM

This revision is now accepted and ready to land.Jul 26 2018, 10:01 AM

Thanks. Can you do the commit? I do not have commit access.

This revision was automatically updated to reflect the committed changes.